Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISA deviation #21

Open
michK opened this issue Jun 15, 2017 · 6 comments
Open

ISA deviation #21

michK opened this issue Jun 15, 2017 · 6 comments

Comments

@michK
Copy link

michK commented Jun 15, 2017

Good day.

This is not really an issue with the code, but I am not sure where else to ask.

Does skaero provide the ability to add a deviation from ISA conditions?

Regards

@astrojuanlu
Copy link
Member

Hi @michK, thanks for asking! We considered adding ISA deviations but were not able to think of a useful API. Do you have specific ideas on this?

@michK
Copy link
Author

michK commented Jun 21, 2017

Hi @Juanlu001. The first thing that comes to mind is something like:

h, T, p, rho = coesa.table(1000, isa=15)

In the code, it can work like:

  • First return temperature at 0 altitude
  • Add isa increment to that value
  • Find altitude in standard atmosphere that has that temperature, with fsolve or something
  • Return h, T, p, rho at that altitude

Do you think that would work?

@astrojuanlu
Copy link
Member

Looks good to me, though our experts in atmospheric topics are @AlexS12 and @martosc :) If you are willing to send a pull request, I can help you with the code and git in case you need it.

@michK
Copy link
Author

michK commented Jun 25, 2017

I forked the project and will see if I have some time to work on that, although I cannot promise it since I am quite busy with other things, as everyone always are (-:

Perhaps it will make sense too first make sure that what I proposed is physically correct?

@AlexS12
Copy link
Member

AlexS12 commented Jun 25, 2017

Hi @michK, thanks for your interest. I think we didn't implement that because we weren't able to find any data for the tests. Do you have any idea on where we could find them?
Any way, I think it is a good feature to add!

@michK
Copy link
Author

michK commented Jun 25, 2017

Hi @AlexS12. Unfortunately I don't really know of such data and on further thought I realized the approach I initially suggested is not correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants