Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFW regression on Develop branch #284

Open
pedrocamargo opened this issue Nov 18, 2021 · 2 comments
Open

CFW regression on Develop branch #284

pedrocamargo opened this issue Nov 18, 2021 · 2 comments
Assignees

Comments

@pedrocamargo
Copy link
Contributor

Purpose of use
Development

Describe the bug
CFW is no longer working, and is causing tests to fail

To Reproduce
See #283

@janzill
Copy link
Contributor

janzill commented Jan 16, 2022

To summarise the discussion in #283, whitespace changes in bpr.pyx led to the bug. Changing it back slightly altered traffic assignment test results, see #293. I'm removing the labels here (bug and critical) because they do not apply anymore but I'm keeping this issue open for now because I want to understand what is happening. It could be that very small changes in results (numerical precision) lead to larger differences in the step finding routine.

@janzill janzill removed bug Something isn't working CRITICAL labels Jan 16, 2022
@janzill
Copy link
Contributor

janzill commented Jan 16, 2022

Things to look at:

  • making sure we use double precision in calculations everywhere
  • compare generated c++ code before and after white-space changes in bpr.pyx
  • investigate step finding optimisation parameters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants