Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add «uBlock Filters» #654

Open
DandelionSprout opened this issue Aug 5, 2022 · 10 comments
Open

Add «uBlock Filters» #654

DandelionSprout opened this issue Aug 5, 2022 · 10 comments

Comments

@DandelionSprout
Copy link
Member

I know there's probably a fair few agreements between the AdGuard and uBO teams regarding the use of each others' main lists, but I still feel that https://raw.githubusercontent.com/uBlockOrigin/uAssets/master/filters/filters.txt could be considered for inclusion in AdGuard products, on the grounds that:

  1. It is likely to cover many sites that haven't been reported to the "AdGuard Filters" repo yet. One of likely hundreds, or thousands, of cases is www.citationmachine.net AdguardFilters#126257
  2. I can't find any previous instances on https://github.com/AdguardTeam/FiltersRegistry/issues?q=is%3Aissue+ublock+filters+ of anyone proposing adding that list yet.
  3. At the time of writing, I'm unsure to which extent uBO's shorthand syntaxes (e.g. $1p, $doc, $xhr, $ghide) would be accepted by AdGuard products when used in custom filterlists, which would necessitate making it an included filterlist that makes use of https://github.com/AdguardTeam/FiltersCompiler and similar repos.
@scripthunter7
Copy link
Member

scripthunter7 commented Aug 7, 2022

I'm unsure to which extent uBO's shorthand syntaxes accepted by AdGuard products

From the list you attached, only the following rules are not compatible with AdGuard (based on TSUrlFilter conversion, the filter compiler also uses TSUrlFilter):

  • Line 262 */fuckadblock-$script,redirect=fuckadblock.js-3.2.0: "$redirect modifier is invalid"
  • Line 263 */fuckadblock.$script,redirect=fuckadblock.js-3.2.0: "$redirect modifier is invalid"
  • Line 266 */blockadblock.$script,redirect=fuckadblock.js-3.2.0: "$redirect modifier is invalid"
  • ...
Show all
  • Line 262 */fuckadblock-$script,redirect=fuckadblock.js-3.2.0: "$redirect modifier is invalid"
  • Line 263 */fuckadblock.$script,redirect=fuckadblock.js-3.2.0: "$redirect modifier is invalid"
  • Line 266 */blockadblock.$script,redirect=fuckadblock.js-3.2.0: "$redirect modifier is invalid"
  • Line 267 */blockadblock-$script,redirect=fuckadblock.js-3.2.0: "$redirect modifier is invalid"
  • Line 271 */wp-adblock-$script,redirect=fuckadblock.js-3.2.0: "$redirect modifier is invalid"
  • Line 275 ||s3.amazonaws.com/homad-global-configs.schneevonmorgen.com/hd-main.js$script,domain=autobild.de|cinema.de|computerbild.de|cdnapi.kaltura.com|focus.de|spieleaffe.de|sueddeutsche.de,redirect=hd-main.js: "$redirect modifier is invalid"
  • Line 276 ||svonm.com/hd-main.js$script,redirect=hd-main.js,domain=cinema.de|cdnapi.kaltura.com: "$redirect modifier is invalid"
  • Line 333 ||g9g.eu^*fa.js$script,redirect=fuckadblock.js-3.2.0: "$redirect modifier is invalid"
  • Line 334 ||8s8.eu^*fa.js$script,redirect=fuckadblock.js-3.2.0: "$redirect modifier is invalid"
  • Line 346 ||ligatus.com/*/angular-tag.js$script,redirect=ligatus.com/*/angular-tag.js: "$redirect modifier is invalid"
  • Line 348 ||ligatus.com/*/angular-tag-https.js$script,redirect=ligatus.com/*/angular-tag.js: "$redirect modifier is invalid"
  • Line 458 ||svonm.com/hd-main.js$script,redirect=hd-main.js,domain=kicker.de|myspass.de|spielaffe.de|tele5.de: "$redirect modifier is invalid"
  • Line 479 ||popads.net/pop.js$script,redirect=popads.net.js: "$redirect modifier is invalid"
  • Line 665 ||npttech.com/advertising.js$important,script,redirect=fuckadblock.js-3.2.0: "$redirect modifier is invalid"
  • Line 873 ||download.mokeedev.com/js/jquery-common.js.*$1p,script,redirect=fuckadblock.js-3.2.0: "$redirect modifier is invalid"
  • Line 1042 *$popunder,3p,domain=vivo.sx: "Unknown modifier: popunder"
  • Line 1212 *$3p,popunder,domain=xhamster.*: "Unknown modifier: popunder"
  • Line 1278 ||googlesyndication.com/pagead/js/adsbygoogle.js$script,redirect=googletagmanager.com/gtm.js:10,domain=breitbart.com: "$redirect modifier is invalid"
  • Line 1653 *$popunder,domain=s.to|serienstream.*: "Unknown modifier: popunder"
  • Line 1683 ||googlesyndication.com/pagead/js/adsbygoogle.js$script,redirect=noopjs:10,domain=iptvbin.com: "$redirect modifier is invalid"
  • Line 2419 ||googlesyndication.com/pagead/js/adsbygoogle.js$script,redirect=noopjs:10,domain=shidurlive.com: "$redirect modifier is invalid"
  • Line 2462 *$popunder,3p,domain=txxx.*: "Unknown modifier: popunder"
  • Line 2713 ||livesports.pw/adblock.js$script,1p,redirect=fuckadblock.js-3.2.0: "$redirect modifier is invalid"
  • Line 3008 *$popunder,domain=realgfporn.com: "Unknown modifier: popunder"
  • Line 3958 *$popunder,domain=xfreehd.com,3p: "Unknown modifier: popunder"
  • Line 4012 *$popunder,3p,domain=bs.to|burningseries.*: "Unknown modifier: popunder"
  • Line 4866 *$popunder,domain=acortalo.*|acortar.*|insurances.tips|megadescarga.net|megadescargas.net: "Unknown modifier: popunder"
  • Line 5421 ||redirector.desbloqueador.org/redirect?given=$popup,popunder: "Unknown modifier: popunder"
  • Line 5734 ||ref-dir.xyz^$popunder: "Unknown modifier: popunder"
  • Line 5793 ||googlesyndication.com/pagead/js/adsbygoogle.js$script,redirect=noopjs:10,domain=arlinadzgn.com|idntheme.com: "$redirect modifier is invalid"
  • Line 5945 ||googlesyndication.com/pagead/js/adsbygoogle.js$script,redirect=noopjs:10,domain=2pi.pw: "$redirect modifier is invalid"
  • Line 6338 ||filecrypt.*^$popunder: "Unknown modifier: popunder"
  • Line 6985 *$popunder,domain=hotpornfile.org: "Unknown modifier: popunder"
  • Line 7112 ||booking.com^$popunder,domain=viamichelin.*: "Unknown modifier: popunder"
  • Line 7256 *$popunder,3p,domain=imgrock.pw: "Unknown modifier: popunder"
  • Line 7265 *$popunder,3p,domain=imgtorrnt.in: "Unknown modifier: popunder"
  • Line 7569 ||googlesyndication.com/pagead/js/adsbygoogle.js$script,redirect=noopjs:10,domain=tanked.io: "$redirect modifier is invalid"
  • Line 7889 ||googlesyndication.com/pagead/js/adsbygoogle.js$script,redirect=noopjs:10,domain=htnovo.net: "$redirect modifier is invalid"
  • Line 8310 *$popunder,domain=zbporn.com: "Unknown modifier: popunder"
  • Line 8412 *$popunder,domain=camsexvideo.net: "Unknown modifier: popunder"
  • Line 8707 ||googlesyndication.com/pagead/js/adsbygoogle.js$script,redirect=noopjs:10,domain=moongourd.com: "$redirect modifier is invalid"
  • Line 9150 ||googlesyndication.com/pagead/js/adsbygoogle.js$script,redirect=noopjs:10,domain=kurazone.net: "$redirect modifier is invalid"
  • Line 9246 *$popunder,domain=oboom.com: "Unknown modifier: popunder"
  • Line 9274 ||googlesyndication.com/pagead/js/adsbygoogle.js$script,redirect=noopjs:10,domain=marfilius.blogspot.com: "$redirect modifier is invalid"
  • Line 9724 ||googlesyndication.com/pagead/js/adsbygoogle.js$script,redirect=noopjs:10,domain=themeplatinum.blogspot.com: "$redirect modifier is invalid"
  • Line 9833 ||googlesyndication.com/pagead/js/adsbygoogle.js$script,redirect=noopjs:10,domain=naminakiky.com: "$redirect modifier is invalid"
  • Line 9866 *$popunder,domain=eroclips.org: "Unknown modifier: popunder"
  • Line 10249 ||googlesyndication.com/pagead/js/adsbygoogle.js$script,redirect-rule=noopjs:10,domain=simsdom.com: "$redirect modifier is invalid"
  • Line 10324 *$popunder,domain=illicoporno.com: "Unknown modifier: popunder"
  • Line 10533 ||googlesyndication.com/pagead/js/adsbygoogle.js$script,redirect=noopjs:10,domain=insurance-corporate.blogspot.com: "$redirect modifier is invalid"
  • Line 10655 ||lovquiz.com^$popunder: "Unknown modifier: popunder"
  • Line 10799 ref-dir.com^$popunder: "Unknown modifier: popunder"
  • Line 10805 ||iwalif.com^$popunder: "Unknown modifier: popunder"
  • Line 10809 *$popunder,domain=drivelinks.me|hackshort.me|latinolinks.site|pelislinks.me: "Unknown modifier: popunder"
  • Line 11118 ||googlesyndication.com/pagead/js/adsbygoogle.js$script,redirect=noopjs:10,domain=megafile.io: "$redirect modifier is invalid"
  • Line 11404 *$popunder,domain=cambro.tv: "Unknown modifier: popunder"
  • Line 11442 ||googlesyndication.com/pagead/js/adsbygoogle.js$script,redirect=noopjs:10,domain=gembelcit.net: "$redirect modifier is invalid"
  • Line 11871 ||paladinsdecks.com/fileadmin/*/fab.min.js$script,1p,redirect=fuckadblock.js-3.2.0: "$redirect modifier is invalid"
  • Line 11948 @@||zplayer.live^$cname: "Unknown modifier: cname"
  • Line 11955 ||googlesyndication.com/pagead/js/adsbygoogle.js$script,redirect=noopjs:10,domain=gsmcracktools.blogspot.com: "$redirect modifier is invalid"
  • Line 12028 ||googlesyndication.com/pagead/js/adsbygoogle.js$script,redirect=noopjs:10,domain=freeiptv.life: "$redirect modifier is invalid"
  • Line 12197 ||googlesyndication.com/pagead/js/adsbygoogle.js$script,redirect=noopjs:10,domain=kharisma-adzana.blogspot.com: "$redirect modifier is invalid"
  • Line 12688 ||googlesyndication.com/pagead/js/adsbygoogle.js$script,redirect=noopjs:10,domain=abdoutech.com: "$redirect modifier is invalid"
  • Line 12698 ||acortame.xyz^$popunder: "Unknown modifier: popunder"
  • Line 12746 ||googlesyndication.com/pagead/js/adsbygoogle.js$script,redirect=noopjs:10,domain=firm-ware27.blogspot.com|flash-reset.blogspot.com: "$redirect modifier is invalid"
  • Line 12822 ||googlesyndication.com/pagead/js/adsbygoogle.js$script,redirect=noopjs:10,domain=tunovelaligera.com: "$redirect modifier is invalid"
  • Line 12998 ||googlesyndication.com/pagead/js/adsbygoogle.js$script,redirect=noopjs:10,domain=windowcleaningforums.co.uk: "$redirect modifier is invalid"
  • Line 13400 ||google-analytics.com/analytics.js$script,redirect=google-analytics.com/analytics.js,important,domain=solvetube.site: "$redirect modifier is invalid"
  • Line 13729 *$popunder,3p,domain=alemannia-aachen.de: "Unknown modifier: popunder"
  • Line 14134 *$popunder,3p,domain=spankbang.com: "Unknown modifier: popunder"
  • Line 14162 ||googlesyndication.com/pagead/js/adsbygoogle.js$script,redirect=noopjs:10,domain=babel.com: "$redirect modifier is invalid"
  • Line 14254 ||googlesyndication.com/pagead/js/adsbygoogle.js$script,redirect=noopjs:10,domain=atv.pw: "$redirect modifier is invalid"
  • Line 14357 *$popunder,domain=smutr.com,3p: "Unknown modifier: popunder"
  • Line 14430 ||googlesyndication.com/pagead/js/adsbygoogle.js$script,redirect=noopjs:10,domain=tokubatch.com: "$redirect modifier is invalid"
  • Line 14480 ||googlesyndication.com/pagead/js/adsbygoogle.js$script,redirect=noopjs:10,domain=mysterious-dev.com: "$redirect modifier is invalid"
  • Line 14613 *$popunder,3p,domain=tubepornclassic.com: "Unknown modifier: popunder"
  • Line 14802 @@||crackle.com^$cname: "Unknown modifier: cname"
  • Line 14939 *$popunder,3p,domain=multiup.*: "Unknown modifier: popunder"
  • Line 14982 ||googlesyndication.com/pagead/js/adsbygoogle.js$script,redirect=noopjs:10,domain=spieleklassiker.com: "$redirect modifier is invalid"
  • Line 15020 ||googlesyndication.com/pagead/js/adsbygoogle.js$script,redirect=noopjs:10,domain=tsforum.pl: "$redirect modifier is invalid"
  • Line 15114 *$popunder,3p,domain=m.pornoxo.com: "Unknown modifier: popunder"
  • Line 15323 ||googlesyndication.com/pagead/js/adsbygoogle.js$script,redirect=noopjs:10,domain=collegestash.com: "$redirect modifier is invalid"
  • Line 15388 ||googlesyndication.com/pagead/js/adsbygoogle.js$script,redirect=noopjs:10,domain=ktab3ndna.com: "$redirect modifier is invalid"
  • Line 16276 ||salaload.me^$popunder: "Unknown modifier: popunder"
  • Line 16498 ||googlesyndication.com/pagead/js/adsbygoogle.js$script,redirect=noopjs:10,domain=felanovia.com: "$redirect modifier is invalid"
  • Line 17125 ||googlesyndication.com/pagead/js/adsbygoogle.js$script,redirect=noopjs:10,domain=folhabv.com.br: "$redirect modifier is invalid"
  • Line 17151 ||googlesyndication.com/pagead/js/adsbygoogle.js$script,redirect=noopjs:10,domain=okyanime.com: "$redirect modifier is invalid"
  • Line 17437 *$popunder,domain=convert2mp3.tv,3p: "Unknown modifier: popunder"
  • Line 17464 ||googlesyndication.com/pagead/js/adsbygoogle.js$script,redirect=noopjs:10,domain=adnan-tech.com: "$redirect modifier is invalid"
  • Line 17782 *$popunder,domain=jacquieetmichelelite.com: "Unknown modifier: popunder"
  • Line 17879 ||googlesyndication.com/pagead/js/adsbygoogle.js$script,redirect=noop.js:10,domain=1shortlink.com: "$redirect modifier is invalid"
  • Line 18109 ||googlesyndication.com/pagead/js/adsbygoogle.js$script,redirect=noopjs:10,domain=infolokerserang.com: "$redirect modifier is invalid"
  • Line 18899 ||googlesyndication.com/pagead/js/adsbygoogle.js$script,redirect=noopjs:10,domain=apk.sekilastekno.com: "$redirect modifier is invalid"
  • Line 19903 ||pagead2.googlesyndication.com/pagead/js/adsbygoogle.js$script,xhr,redirect-rule=googlesyndication_adsbygoogle.js:5,domain=~zipextractor.app: "$redirect modifier is invalid"

Related: AdguardTeam/tsurlfilter#59

@zloyden
Copy link
Contributor

zloyden commented Aug 12, 2022

Actually, we are considering doing this, but when we have full compatibility support.

@zloyden zloyden closed this as completed Aug 12, 2022
@kodiakhub
Copy link

kodiakhub commented Aug 30, 2023

I'm curious about the current status of this issue. Also, I can give an example of my issue:

AdguardTeam/AdguardFilters#160414

Also, there are those who state that there are conflicts on the YouTube site, especially with the uBO and AdGuard filters. It must be difficult to filter separately. For example, See:

YouTube Anti-Adblock and Ads - Weekly Thread August 28, 2023

@ameshkov
Copy link
Member

Maybe we should exclude YT rules from the uBO version of AdGuard Base filter?

When dealing with complicated adblock circumvention it's better to not mess with uBO filter list.

@AdguardTeam/filters-maintainers what do you think?

@AdamWr
Copy link
Member

AdamWr commented Aug 30, 2023

Currently trusted-replace-fetch-response scriptlet is used to block ads and avoid adblock detection, so it should not interfere with uBO rules.
But if necessary it can be excluded.

@kodiakhub
Copy link

Maybe we should exclude YT rules from the uBO version of AdGuard Base filter?

Why a solution like this? Actually, I don't think using different filter lists is of any benefit to the end user. For example, why not at least create a common world filter for most popular sites like Facebook, Instagram, Youtube, Spotify, Twitter and Twitch for uBO&AdGuard and others? Because users everywhere in the world use these sites. So, a filter maintainer from one country with a VPN cannot fully solve another country's problem. The most example of this issue is here:

uBlockOrigin/uAssets#18148 (comment)

This issue takes 5 months to be resolved by AdGuard, how long would it normally take if I as a user had not reported this issue with the help of other users? Who knows. Hopefully AdGuard can provide in time full support for uBO filters without any issues. Thanks! 👍

@DandelionSprout
Copy link
Member Author

DandelionSprout commented Aug 30, 2023

In my eyes, the situation is simple:

uBlock Origin includes AdGuard Base Filter (which they really should've made a default list years ago but still hasn't).

It is therefore not only fair, but borderline required, for AdGuard to include 'uBlock Filters - Ads' in order to market itself as modern, innovative, and an adapter of new(?) tech.

@ameshkov
Copy link
Member

I think we're discussing different topics here.

The first topic is how to avoid messing with uBO users who have AdGuard Base filter enabled. The lists solve similar issues but may use different ways to do that and interfere with each other. Since AdGuard does not include uBO filter lists yet, I think it's a normal solution to make the uBO version of AdGuard Base filter compatible.

Now to the second topic: including uBO filters to the list of available filters in AdGuard. We'll run into the same issue, but now we'll need to make the uBO list compatible with AdGuard Base filter.

I think that the only good solution to compatibility issues is filter lists consolidation. Also, in my opinion the only viable place to do that is EasyList. AdGuard and uBO could continue to maintain their "Base filter" and "uBlock Filters - Ads", but move a large chunk of rules to EasyList. There will be some technical difficulties with that, i.e. uBO Filters maintainers will need to use uBO syntax, AdGuard filters maintainers prefer AdGuard syntax, etc. All these difficulties can be solved, after all we made AGLint and AGTree that can be used to automatically maintain EasyList versions compatible with all ad blockers. Note, that such consolidation does not mean that the lists can be merged completely. There are differencies in EL/AG/uBO filters policies and some rules can't be added to EL, but the outcome will still be positive.

PS: let me reopen this issue for the sake of the discussion.

@ameshkov ameshkov reopened this Aug 31, 2023
@kodiakhub
Copy link

For example, why not at least create a common world filter for most popular sites like Facebook, Instagram, Youtube, Spotify, Twitter and Twitch for uBO&AdGuard and others? Because users everywhere in the world use these sites.

There are differencies in EL/AG/uBO filters policies and some rules can't be added to EL, but the outcome will still be positive.

At least ads etc on websites that are popular all over the world. For this, if all of this filter policy is compliant, it will be very useful. If other regional sites are out of this. This is not a problem! Because the most important thing is that sites such as Youtube are likely to be updated very frequently, and I think it would be more logical to solve the problems with the community of filter maintaners/volunteers in the world when there are different results in different countries. I hope it's understandable what I want to say. As a user, please excuse me if I'm wrong. 👍

@DandelionSprout
Copy link
Member Author

DandelionSprout commented Aug 31, 2023

There seems to be rather sharp differences in response times between the 3 repos in question; as well as how uBlock Filters being non-profit appears to somehow have made it immune to being sued for anti-anti-adblock entries (whereas AdGuard Filters and EasyList supposedly get frequent bossy threats from German newssites). These are topics I plan to bring up in the Ad-Filtering Dev Summit panel debate in October (despite the panel not showing up on the Summit's speaker list yet), but it's a solid 5 weeks away still.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants