-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add «uBlock Filters» #654
Comments
From the list you attached, only the following rules are not compatible with AdGuard (based on TSUrlFilter conversion, the filter compiler also uses TSUrlFilter):
Show all
Related: AdguardTeam/tsurlfilter#59 |
Actually, we are considering doing this, but when we have full compatibility support. |
I'm curious about the current status of this issue. Also, I can give an example of my issue: AdguardTeam/AdguardFilters#160414 Also, there are those who state that there are conflicts on the YouTube site, especially with the uBO and AdGuard filters. It must be difficult to filter separately. For example, See: YouTube Anti-Adblock and Ads - Weekly Thread August 28, 2023 |
Maybe we should exclude YT rules from the uBO version of AdGuard Base filter? When dealing with complicated adblock circumvention it's better to not mess with uBO filter list. @AdguardTeam/filters-maintainers what do you think? |
Currently |
Why a solution like this? Actually, I don't think using different filter lists is of any benefit to the end user. For example, why not at least create a common world filter for most popular sites like Facebook, Instagram, Youtube, Spotify, Twitter and Twitch for uBO&AdGuard and others? Because users everywhere in the world use these sites. So, a filter maintainer from one country with a VPN cannot fully solve another country's problem. The most example of this issue is here: uBlockOrigin/uAssets#18148 (comment) This issue takes 5 months to be resolved by AdGuard, how long would it normally take if I as a user had not reported this issue with the help of other users? Who knows. Hopefully AdGuard can provide in time full support for uBO filters without any issues. Thanks! 👍 |
In my eyes, the situation is simple: uBlock Origin includes AdGuard Base Filter (which they really should've made a default list years ago but still hasn't). It is therefore not only fair, but borderline required, for AdGuard to include 'uBlock Filters - Ads' in order to market itself as modern, innovative, and an adapter of new(?) tech. |
I think we're discussing different topics here. The first topic is how to avoid messing with uBO users who have AdGuard Base filter enabled. The lists solve similar issues but may use different ways to do that and interfere with each other. Since AdGuard does not include uBO filter lists yet, I think it's a normal solution to make the uBO version of AdGuard Base filter compatible. Now to the second topic: including uBO filters to the list of available filters in AdGuard. We'll run into the same issue, but now we'll need to make the uBO list compatible with AdGuard Base filter. I think that the only good solution to compatibility issues is filter lists consolidation. Also, in my opinion the only viable place to do that is EasyList. AdGuard and uBO could continue to maintain their "Base filter" and "uBlock Filters - Ads", but move a large chunk of rules to EasyList. There will be some technical difficulties with that, i.e. uBO Filters maintainers will need to use uBO syntax, AdGuard filters maintainers prefer AdGuard syntax, etc. All these difficulties can be solved, after all we made AGLint and AGTree that can be used to automatically maintain EasyList versions compatible with all ad blockers. Note, that such consolidation does not mean that the lists can be merged completely. There are differencies in EL/AG/uBO filters policies and some rules can't be added to EL, but the outcome will still be positive. PS: let me reopen this issue for the sake of the discussion. |
At least ads etc on websites that are popular all over the world. For this, if all of this filter policy is compliant, it will be very useful. If other regional sites are out of this. This is not a problem! Because the most important thing is that sites such as Youtube are likely to be updated very frequently, and I think it would be more logical to solve the problems with the community of filter maintaners/volunteers in the world when there are different results in different countries. I hope it's understandable what I want to say. As a user, please excuse me if I'm wrong. 👍 |
There seems to be rather sharp differences in response times between the 3 repos in question; as well as how uBlock Filters being non-profit appears to somehow have made it immune to being sued for anti-anti-adblock entries (whereas AdGuard Filters and EasyList supposedly get frequent bossy threats from German newssites). These are topics I plan to bring up in the Ad-Filtering Dev Summit panel debate in October (despite the panel not showing up on the Summit's speaker list yet), but it's a solid 5 weeks away still. |
I know there's probably a fair few agreements between the AdGuard and uBO teams regarding the use of each others' main lists, but I still feel that https://raw.githubusercontent.com/uBlockOrigin/uAssets/master/filters/filters.txt could be considered for inclusion in AdGuard products, on the grounds that:
$1p
,$doc
,$xhr
,$ghide
) would be accepted by AdGuard products when used in custom filterlists, which would necessitate making it an included filterlist that makes use of https://github.com/AdguardTeam/FiltersCompiler and similar repos.The text was updated successfully, but these errors were encountered: