Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The advanced rules existing in only 3rd-party filter do not work #2285

Open
3 tasks done
piquark6046 opened this issue Jan 22, 2024 · 6 comments
Open
3 tasks done

The advanced rules existing in only 3rd-party filter do not work #2285

piquark6046 opened this issue Jan 22, 2024 · 6 comments

Comments

@piquark6046
Copy link
Member

Prerequisites

Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.

  • I am running the latest version
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed

Issue Details

  • AdGuard version:
    • 4.5.2
  • Device model and storage size:
    • iPhone SE2
  • Operating system and version:
    • iOS 17.2.1
  • Browser or App:
    • Safari

Expected Behavior

The advanced rules existing in only 3rd-party filter does work well even if AdGuard Mobile Ads filter is disabled.

Actual Behavior

The advanced rules existing in only 3rd-party filter does not work if AdGuard Mobile Ads filter is disabled.

Screenshots

https://cdn.adguard.info/sitereports/kyiji75f1v4ock8g4w00skgw84g00k8sw94bj1p9a8.jpg?nc=1
https://cdn.adguard.info/sitereports/1zk2okjvxb6s40oc000ok844sgos0gc3t0p4eeu6ec.jpg?nc=1

Additional Information

The following rules exist in List-KR filter and AdGuard Mobile Ads filter:

m.fmkorea.com#%#//scriptlet('json-prune', 'tpl apply', 'tpl.[].c', '/fmkorea.com.[A-z]{8,}.js/')
m.fmkorea.com#$?#body[class*="mac_os"] div[class="hd"] ~ *[id][class*=" "]:matches-css(padding: /5px 10px 20px/):matches-css(height: /^[0-9]{2,3}/) { remove: true; }
m.fmkorea.com#$?#header[class="hd"] ~ .fmad_wrapper ~ *[class]:matches-css(padding: /5px 10px 20px/):matches-css(height: /^[0-9]{2,3}/) { remove: true; }
m.fmkorea.com#$?#body div:is(.bd, .hd) div[style] > *[class*=" "]:matches-css(padding: /5px 10px 20px/):matches-css(height: /^[0-9]{2,3}/) { remove: true; }

To reproduce the issue, you may to use a real Korean IP address.

Related issues:
AdguardTeam/AdguardFilters#168573 (comment)
AdguardTeam/AdguardFilters#168573 (comment)

@maxikuzmin
Copy link

@piquark6046 to troubleshoot this issue, we need to get the app logs.

Here's what we need you to do:

  • Open Settings --> General --> Turn Advanced mode on --> Advanced settings --> Turn Debug logs switch on;
  • Reproduce the issue and remember the exact time when it happened;
  • Disable "DNS Privacy";
  • Open the settings --> Support --> Export logs;
  • System popup will be opened --> Choose "Mail" app
  • Enter apple@adguard.com as a recipient;
  • Mention this issue number in the subject and add the time the issue was reproduced at.

@piquark6046
Copy link
Member Author

Sent.

@maxikuzmin
Copy link

@piquark6046 strange behavior, judging from the logs the rules are applied. I was also able to reproduce this problem, Thank you, we will look into this problem

@piquark6046
Copy link
Member Author

Please note that the scriptlet rule was updated.

@piquark6046
Copy link
Member Author

Please add the following exception rules if you are about to debug:

m.fmkorea.com#@$?#body[class^="mac_os"] > div[id^="bd_"].bd:not([style]):has(> p > a[href]:matches-property(listeners.click) ~ a[href]:matches-property(listeners.click):contians(/^http/)) { remove: true; }
m.fmkorea.com#@$?#body[class="mac_os"] > .bd > div[style]:has(> .bd_mobile > p > a[href]:matches-property(listeners.click) ~ a[href]:matches-property(listeners.click):contians(/^http/)) { remove: true; }

@piquark6046
Copy link
Member Author

@maxikuzmin Sent a 2nd debugging log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants