Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the case with too many DNS rules gracefully #2227

Open
Zsombe opened this issue Sep 25, 2023 · 3 comments
Open

Handle the case with too many DNS rules gracefully #2227

Zsombe opened this issue Sep 25, 2023 · 3 comments

Comments

@Zsombe
Copy link

Zsombe commented Sep 25, 2023

In AdGuard iOS when the sum of all DNS rules exceeds approximately 535000 rules. WiFI crashes when this number of rules is exceeded.

@ameshkov
Copy link
Member

ameshkov commented Sep 26, 2023

DnsLibs notifies AdGuard that the engine exceeds the maximum allowed memory limit and it then forcibly stops the tunnel, this may look like a Wi-Fi crash because the tunnel is then restarted due to an "on demand" rule.

The solution would be to start the tunnel anyway with a limited engine instance and notify the user about that via a normal OS notification. The error code that should be used is AGDPE_MEM_LIMIT_REACHED.

@adguard-bot adguard-bot changed the title Too many DNS rules crashes WiFi Handle the case with too many DNS rules gracefully Sep 26, 2023
@Greigh
Copy link

Greigh commented Oct 16, 2023

I have this issue on cellar, as well. It just breaks the data functionality of my phone completely. Will 4.6 fix this as well?

@ameshkov
Copy link
Member

It will work, but it does not mean that it's a good idea to use a blocklist that's heavier than the limit as all rules above the limit will be discarded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants