Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded or predefined whitelist #1134

Closed
ammnt opened this issue Oct 29, 2019 · 4 comments
Closed

Hardcoded or predefined whitelist #1134

ammnt opened this issue Oct 29, 2019 · 4 comments
Labels

Comments

@ammnt
Copy link

ammnt commented Oct 29, 2019

Hello,

I recommend you add a hardcoded or predefined whitelist for the following domains:
adguard.com
www.adguard.com
github.com
forum.adguard.com
auth.adguard.com
adguardteam.github.io
dns.adguard.com
kb.adguard.com
github.githubassets.com
camo.githubusercontent.com
api.adguard.com
api-b.adguard.com
api-c.adguard.com
api-d.adguard.com
etc.

This will prevent the availability of hosts required for technical support.

Thank you.

@ghost
Copy link

ghost commented Oct 29, 2019

Disagree. I believe AG dislike too because they prefer let full control for users. 😉

@phixion
Copy link

phixion commented Oct 30, 2019

yeah, bad idea. a compromise would be to provide a curated, transparent whitelist of addresses that are required to run their services that users can add to their lists.

@ammnt
Copy link
Author

ammnt commented Oct 30, 2019

@phixion, this is acceptable too, i think. Agree.

@ammnt ammnt changed the title Hardcoded whitelist Hardcoded or predefined whitelist Oct 30, 2019
@ameshkov
Copy link
Member

Tbh, I am not a fan of whitelists (especially if they're hardcoded), and I don't think we should interfere if someone wants to block our domains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants