Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assertContains & assertNotContains with viewMatcher #481

Open
moutyque opened this issue Mar 1, 2023 · 1 comment
Open

assertContains & assertNotContains with viewMatcher #481

moutyque opened this issue Mar 1, 2023 · 1 comment

Comments

@moutyque
Copy link
Contributor

moutyque commented Mar 1, 2023 •
edited

The current implementations of assertContains & assertNotContains do not include an implementation that allows viewMatcher as parameter.
@moutyque moutyque changed the title assertContains with viewMatcher assertContains & assertNotContains with viewMatcher Mar 1, 2023
@moutyque
Copy link
Contributor Author

moutyque commented Mar 1, 2023

After my first PR I wanted to add some new methods with viewmatchers.
However, I am confused with method name and goals.
It seems to me that exist and contain are similar. The only difference I see i the display for contains, but it is not understable from the name.

So what was the idea behind assertContain vs assertExist same with negative version of the methods ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@moutyque