Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pageCount only accepts number but I want to pass a string #488

Open
HamaDler opened this issue May 29, 2023 · 0 comments · May be fixed by #490
Open

pageCount only accepts number but I want to pass a string #488

HamaDler opened this issue May 29, 2023 · 0 comments · May be fixed by #490

Comments

@HamaDler
Copy link

HamaDler commented May 29, 2023

So my pageCount sometimes gets too big (in the thousands), and I want to add digit separators like so 1565 => 1,656.

but passing "1,656" as a string is not allowed and if I use normal js numbers with separators 1,555 it just assumes I am trying to pass in two props, 1 and 555.

Is there any workarounds for this?

I want to achieve something like the image below. I customized the container with css, but I can't do the number formatting with CSS, and with JS it just turns it to string which the inner element doesn't accept.

image

dasanik2001 added a commit to dasanik2001/react-paginate that referenced this issue Jun 5, 2023
@dasanik2001 dasanik2001 linked a pull request Jun 5, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant