Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parametrizing MixedDataLoader option for discrete variable #100

Open
timonmerk opened this issue Oct 29, 2023 · 0 comments
Open

Parametrizing MixedDataLoader option for discrete variable #100

timonmerk opened this issue Oct 29, 2023 · 0 comments
Assignees

Comments

@timonmerk
Copy link
Contributor

I have a question regarding the MixedDataLoader

The current docstring specifies that:

Sampling can be configured in different modes:

1. Positive pairs always share their discrete variable.
2. Positive pairs are drawn only based on their conditional,
   not discrete variable.

I am not sure how it's currently possible to do that?

Maybe an option might is to add a boolean keyword positive_sampling to be either conditional or discrete_variable?

In addition, as already mentioned in the docstring of the get_indices function, the priorof the discrete distribution could be specified

- Add the ``empirical`` vs. ``discrete`` sampling modes to this

I will reference a PR here also

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants