Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add binaries to releases section #10

Open
dene14 opened this issue Sep 10, 2020 · 7 comments
Open

Add binaries to releases section #10

dene14 opened this issue Sep 10, 2020 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@dene14
Copy link

dene14 commented Sep 10, 2020

There is onlt source code tarballs in releases section on github right now.
Can we add binaries (*.kar) in addition or as a replacement for it?

@bdellegrazie bdellegrazie self-assigned this Sep 10, 2020
@bdellegrazie bdellegrazie added the enhancement New feature or request label Sep 10, 2020
@bdellegrazie
Copy link

bdellegrazie commented Sep 10, 2020

Hi @dene14 - I'll need to check internally where we can host them. I don't think it will be a huge problem but I haven't thus far because of that.

Just FYI, it is trivially simple to build (JDK 8 + mvn package will get you the .kar file) - i've updated the documentation to include a building section.

@dene14
Copy link
Author

dene14 commented Sep 10, 2020

Yeah, I know... I just noticed that you have pipeline anyway, just pushing to your private artifactory.. I believe Github Releases can be used for that... For e.g.: https://github.com/roboll/helmfile/releases

@csullivannet
Copy link

Since this project is open source, can it use GitHub Actions for free? I might not be able to get to it for a few weeks, but I could look at using Actions to create and publish the .kar archive.

@csullivannet
Copy link

@dene14 @bdellegrazie I've opened a PR that automatically builds and publishes, it generaties artifacts for regular commits and publishes to the release:
#12

@bdellegrazie
Copy link

@csullivannet I have merged your changed but at present it doesn't look like its producing the artefacts or I haven't tied it in properly. I'll recheck it over the weekend.

@csullivannet
Copy link

I can see that you created a release from the commit after you merged the workflow. It should have then kicked off the workflow to create the release bundle.

Let me know how your testing over the weekend goes.

@FOTempel
Copy link

Our deployment tooling for Nexus pulls its plugins from https://repo1.maven.org/maven2/org/sonatype/nexus/plugins/, that would be a great place to put it. Having to compile a plugin ourselves would introduce chicken and egg problems as built artifacts belong in an artifact manager which we're trying to deploy, which we can't because there's no CasC (yet)...
This can be worked around, sure, by including built binaries in the deployment code, but that's ugly and will introduce new problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants