Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming rarely works #1159

Open
Joebeazelman opened this issue Jul 28, 2023 · 3 comments
Open

Renaming rarely works #1159

Joebeazelman opened this issue Jul 28, 2023 · 3 comments

Comments

@Joebeazelman
Copy link

When I try to rename an identifier (the name of a function, procedure, variable, or type) using VS Code's Rename Symbol menu option, it complains that it can't rename it without providing a reason. On other occasions, it lets me go through the process of renaming it but nothing happens. There has only been a few times when it successfully renamed an identifier.

@reznikmm
Copy link
Contributor

We have an improvement that shows more information of failed refactoring in the problem windows. This will be in the next release. We are interested in fixing renaming issue. Please send us any reproducer for this issue.

@Joebeazelman
Copy link
Author

I would have to send you my project which is confidential.

@johnperry-math
Copy link

Please send us any reproducer for this issue.

In my experience, just about any Ada code at all will reproduce it. I used VS Code extensively during the 2023 Advent of Code, and the Rename feature didn't rename anything except the text I had clicked on. It wasn't able even to rename the label after an end keyword.

For example, the following steps reproduce the issue for me:

  1. alr init --bin test_rename
  2. cd test_rename
  3. codium .
  4. open src/test_rename.adb
  5. click on Test_Rename in line 1
  6. press f2
  7. rename Test_Rename to anything at all
  8. observe that line 4 still has end Test_Rename

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants