Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overrides for the iterator methods that do not get the key #86

Open
rklaehn opened this issue May 17, 2021 · 1 comment
Open

Add overrides for the iterator methods that do not get the key #86

rklaehn opened this issue May 17, 2021 · 1 comment

Comments

@rklaehn
Copy link
Contributor

rklaehn commented May 17, 2021

Materializing the keys out of the compact sequences is a significant part of the work. But in some cases you only need the value.

There should be variants of the 2 iter methods that return (Offset, Value) instead of (Offset, Key, Value). That would be faster and fewer mallocs.

@rklaehn
Copy link
Contributor Author

rklaehn commented May 17, 2021

Thinking further about this, you might need a custom projection of the CompactSeq for the keys. E.g. you might need the lamports for sorting, but not the tags.

So maybe extend the iterator with a projection function that is given a reference to the KeySeq and a reference to the bitmap and is supposed to produce an iterator of results?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant