Node Manager: display glitch while adding nodes

[rkuhn]

Right after adding new nodes using the discovery pane, all existing nodes are shown without node names for 2sec. This is probably caused by setting the AppState without transporting already known node details.

[Kelerchian]

Can't reproduce the issue.

But when I add a bit of delay to getNodeDetail. This is the behavior I see. The behavior may or may not be related. This issue might be a side-effect of that behavior.

data-race-in-nodelist.webm

Should we fix this as a part of this issue, or a separate issue? Either way, I'm going to fix the behavior and see if the reported issue is fixed too on the consumer's side.

[rkuhn]

Hmm, this looks weird. What kind of delay did you add where? This might well be something that needs fixing.

[Kelerchian]

I added this on one of the getNodeDetails call.

getNodeDetails({ peer: n.peer, timeout: getTimeoutSec })
  .then(async (res) => {
    await new Promise((res) => setTimeout(res, 5000))
    return res
  })

[rkuhn]

Ah, interesting, yes: if getting responses from Actyx takes longer than the 2sec cycle then there will be problems. But that is part of the design in that we don’t wait for that long for responses from Actyx.

[jmg-duarte]

Next steps for this issue:

• Try to reproduce the issue with a forced 1s delay