Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Role & ARIA-label persist on carousel after 'unslicking' #93

Open
SirDaev opened this issue Jun 15, 2023 · 0 comments · May be fixed by #94
Open

Role & ARIA-label persist on carousel after 'unslicking' #93

SirDaev opened this issue Jun 15, 2023 · 0 comments · May be fixed by #94

Comments

@SirDaev
Copy link

SirDaev commented Jun 15, 2023

When an accessible-slick slider becomes 'unslicked' (via the responsive settings or via jQuery), the role and aria-label that are appended upon 'slicking' persist. This makes for excess attributes that a screen reader will read out when the carousel no longer exists. The role and aria-label should be removed upon destroying the slider.

Minimal demo showing persisting attributes:
https://codepen.io/SirDaev/pen/KKrdoPz

Before (when carousel is initialized):
Screen Shot 2023-06-15 at 10 58 06 AM

After (when carousel is destroyed via unslick):
Screen Shot 2023-06-15 at 10 57 22 AM

@SirDaev SirDaev linked a pull request Jun 15, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant