Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(consumer): Allow editable spin buttons #167

Merged
merged 2 commits into from Nov 24, 2022
Merged

Conversation

mwcampbell
Copy link
Contributor

On Windows, spin buttons are usually editable, and JAWS assumes that they are. So this PR adds spin buttons to the set of roles that can support text ranges.

consumer/src/text.rs Outdated Show resolved Hide resolved
Copy link
Member

@DataTriny DataTriny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So there was a bug and none of us catched it before the refactoring!

@mwcampbell
Copy link
Contributor Author

No, I don't believe there was a bug before. But I know it's correct now, so I'll go ahead and merge.

@mwcampbell mwcampbell merged commit 65a7aa0 into main Nov 24, 2022
@mwcampbell mwcampbell deleted the editable-spin-button branch November 24, 2022 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants