Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portfolio should not choose favourite tokens for users or have Favourites filter selected by default without them choosing it #2712

Open
ltfschoen opened this issue Feb 21, 2024 · 1 comment

Comments

@ltfschoen
Copy link

Describe the bug

  1. If I go to https://apps.acala.network/portfolio to view my portfolio, by default "Favourites" is selected (even though I didn't choose any of the favourites that are shown), so it doesn't show all the possibilities available.
    I believe "All" should be selected by default, and it shouldn't choose favourites automatically without the user choosing them.
    For example, if I swap some DOT for a token that isn't on the list using Acala Swap, and then go back to my portfolio, it doesn't show the token unless I click "All".

Expected Behavior

The UX should make sense.
"Favourites" tab shouldn't be selected by default by the dApp and shouldn't be pre-chosen by the dApp to limit what's shown to new users. Instead "All" tokens should be shown by default unless the user explicitly chooses to filter them by adding them to favourites and specifically clicking "Favourites" to filter only those ones themselves.

Current Behavior

As described above

Steps to Reproduce

See above

Additional context

  • Browser: latest Brave, Firefox, Chrome
@lrcnz
Copy link

lrcnz commented Feb 22, 2024

Yes, favorite selected by default is the current logic, will have a look into the treatment on empty list.

The dapp also remember selections user make, and that becomes default for the wallet+browser, i.e. if you pick All and Hide 0 Balance, it should be the same list when you return next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants