Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] nanovdb/util/cuda in NanoVDB 11 installs to invalid folder #1769

Open
AJpon opened this issue Feb 27, 2024 · 1 comment · May be fixed by #1770
Open

[BUILD] nanovdb/util/cuda in NanoVDB 11 installs to invalid folder #1769

AJpon opened this issue Feb 27, 2024 · 1 comment · May be fixed by #1770
Labels

Comments

@AJpon
Copy link

AJpon commented Feb 27, 2024

Environment

Operating System: Windows 10
Version nanoVDB 11 / Commit SHA: 77f28d1
CMake Version: 3.27.7
Compiler:MSVC 2022

Describe the problem

The release notes state that the CUDA-related headers for NanoVDB have been added to nanovdb/util/cuda, but due to an incorrect CMake script, they are actually installed under nanovdb/util.
This causes projects that use NanoVDB as a library to fail to build when including header files under nanovdb/util/cuda, which destroys the relative reference to nanovdb/util.

To Reproduce

Steps to reproduce the behavior:

  1. Checkout repo 'master'
  2. Run CMake and Build
cmake -S . -B .\build -DCMAKE_INSTALL_PREFIX=D:\openvdb\build\Release -DOPENVDB_BUILD_BINARIES=OFF -DUSE_AX=OFF -DUSE_NANOVDB=ON -DOPENVDB_BUILD_NANOVDB=ON -DNANOVDB_BUILD_TOOLS=OFF -DNANOVDB_USE_CUDA=ON -DCMAKE_TOOLCHAIN_FILE='C:\Program Files\Microsoft Visual Studio\2022\Community\VC\vcpkg\scripts\buildsystems\vcpkg.cmake' -DVCPKG_TARGET_TRIPLET=x64-windows -A x64`
cmake --build .\build --parallel 8 --config Release --target install
  1. Goto .\build\Release\include\nanovdb\util and check directory structure
@AJpon AJpon linked a pull request Feb 27, 2024 that will close this issue
@AJpon
Copy link
Author

AJpon commented Feb 27, 2024

I sent a pull request (#1770 ) to fix this issue

@Idclip Idclip added the nanovdb label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants