Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Remove FindTBB.cmake #1741

Open
mwestphal opened this issue Dec 24, 2023 · 0 comments
Open

[BUG] Remove FindTBB.cmake #1741

mwestphal opened this issue Dec 24, 2023 · 0 comments
Labels

Comments

@mwestphal
Copy link

mwestphal commented Dec 24, 2023

OpenVDB should not provide a FindTBB.cmake (or any Find*.cmake for that matter) because it overrides local TBBConfig.cmake and may miss some components.

In my specific case, it results to the following:

-- OpenVDB ABI Version: 10
CMake Error at /usr/lib/cmake/TBB/TBBTargets.cmake:42 (message):
  Some (but not all) targets in this export set were already defined.

  Targets Defined: TBB::tbb

  Targets not yet defined: TBB::tbbmalloc, TBB::tbbmalloc_proxy,
  TBB::tbbbind_2_5, TBB::irml

Call Stack (most recent call first):
  /usr/lib/cmake/TBB/TBBConfig.cmake:1 (include)
  /home/glow/dev/f3d/deps/install/lib/cmake/vtk-9.3/FindTBB.cmake:75 (find_package)
  /home/glow/dev/f3d/deps/install/lib/cmake/OpenVDB/FindOpenVDB.cmake:493 (find_package)
  /home/glow/dev/f3d/deps/install/lib/cmake/vtk-9.3/VTK-vtk-module-find-packages.cmake:209 (find_package)
  /home/glow/dev/f3d/deps/install/lib/cmake/vtk-9.3/vtk-config.cmake:159 (include)
  cmake/f3dPlugin.cmake:170 (find_package)
  plugins/vdb/CMakeLists.txt:25 (f3d_plugin_build)

Although the FindTBB.cmake providen by OpenVDB does not appear in the stack, removing it solves the issue.

Removing FindTBB.cmake seems to be finxing the issue, but you must be providing it for a reason, so some care may need to be taken for removal.

@mwestphal mwestphal added the bug label Dec 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant