Replace ssize_t with Py_ssize_t #1706
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hi @tetov, thanks for this! Can you sign-off your commit ( |
Signed-off-by: Anton Tetov <anton@tetov.se>
tetov
force-pushed
the
using-ssize_t-equals-Py_ssize_t-semicolon
branch
from
922675c
to
70f0ef4
Compare
|
Hi @Idclip, I've just force pushed after |
Idclip
approved these changes
Jan 5, 2024
richhones
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into the same issue brought up in #1658 while updating the conda-forge feedstock for openvdb.
On Windows and Python > 3.9
ssize_tis undeclared.I opted to replace every ssize_t with Py_ssize_t but this could of course also have been done with a typedef or using. I'm open to other solutions.
I'm attaching two logs from the PR mentioned from conda-forge's CI.
Passes: win_64_numpy1.22python3.9.____cpython Azure CI attached log file
Fails: win_64_numpy1.22python3.10.____cpython Azure CI attached log file
The logs will be removed from Azure CI after 1 month.