-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: llvm 18 compat issue - include libclangAPINotes #1812
base: main
Are you sure you want to change the base?
Conversation
Fixes 1809 Signed-off-by: Larry Gritz <lg@larrygritz.com>
@etsach are you able to try this change on your slide and let us know if it works? It seems safe, and doesn't break anything. But then again, I could never get it to fail. Maybe because you were using llvm 18.0 and I was using 18.1 and maybe they fixed something on their end in between? |
Hi,
This fixes the link error, but then I have another serie of link errors:
undefined reference to `clang::SourceMgrAdapter::~SourceMgrAdapter()'
undefined reference to
`clang::SourceMgrAdapter::handleDiag(llvm::SMDiagnostic const&, void*)'
etc...
And I can't find a library that fix them.
Definitely something else causing an issue.
Le dim. 5 mai 2024 à 05:48, Larry Gritz ***@***.***> a écrit :
… @etsach <https://github.com/etsach> are you able to try this change on
your slide and let us know if it works?
It seems safe, and doesn't break anything. But then again, I could never
get it to fail. Maybe because you were using llvm 18.0 and I was using 18.1
and maybe they fixed something on their end in between?
—
Reply to this email directly, view it on GitHub
<#1812 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACXIPYMDXBVO4JHQY2VSWZTZAWTZHAVCNFSM6AAAAABHHLUVYOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJUGU3TAMRZG4>
.
You are receiving this because you were mentioned.Message ID:
<AcademySoftwareFoundation/OpenShadingLanguage/pull/1812/c2094570297@
github.com>
|
I forgot, this is with LLVM 18.1.3
Le lun. 6 mai 2024 à 22:24, Etienne Sandré-Chardonnal <
***@***.***> a écrit :
… Hi,
This fixes the link error, but then I have another serie of link errors:
undefined reference to `clang::SourceMgrAdapter::~SourceMgrAdapter()'
undefined reference to
`clang::SourceMgrAdapter::handleDiag(llvm::SMDiagnostic const&, void*)'
etc...
And I can't find a library that fix them.
Definitely something else causing an issue.
Le dim. 5 mai 2024 à 05:48, Larry Gritz ***@***.***> a
écrit :
> @etsach <https://github.com/etsach> are you able to try this change on
> your slide and let us know if it works?
>
> It seems safe, and doesn't break anything. But then again, I could never
> get it to fail. Maybe because you were using llvm 18.0 and I was using 18.1
> and maybe they fixed something on their end in between?
>
> —
> Reply to this email directly, view it on GitHub
> <#1812 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ACXIPYMDXBVO4JHQY2VSWZTZAWTZHAVCNFSM6AAAAABHHLUVYOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJUGU3TAMRZG4>
> .
> You are receiving this because you were mentioned.Message ID:
> <AcademySoftwareFoundation/OpenShadingLanguage/pull/1812/c2094570297@
> github.com>
>
|
It all works for me with LLVM18 on MacOS. I'll try to do a Linux LLVM 18 build at work and see I can reproduce. In the mean time, is the change in this PR a step forward that we should merge now, even if there may be additional changes needed after that? |
@etasch, any comments? Should I merge what I have here and then we can try to find any remaining issues? Or are you worried that these changes are not correct? |
Fixes #1809