{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":559748217,"defaultBranch":"main","name":"OpenRV","ownerLogin":"AcademySoftwareFoundation","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2022-10-31T02:19:25.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/40807682?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1716313965.0","currentOid":""},"activityList":{"items":[{"before":"9844fa4c218f3decb61ae29388ac97099ca51a46","after":"0ba6a733689557cc42b925c4bbefcae02fa9d07d","ref":"refs/heads/main","pushedAt":"2024-05-29T13:25:42.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"bernie-laberge","name":"Bernard Laberge","path":"/bernie-laberge","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/117092886?s=80&v=4"},"commit":{"message":"Remove unnecessary cmake build from rocky9 setup (#474)\n\n### Remove unnecessary cmake build from rocky9 setup\r\n\r\n### Linked issues\r\nNA\r\n\r\n### Summarize your change.\r\nRemove unnecessary cmake build from rocky9 build system setup\r\n\r\n### Describe the reason for the change.\r\nRocky Linux 9 comes with cmake version 3.26.5 which is more recent than\r\nthe cmake version 3.24 built from sources that were in the build system\r\nsetup instructions.\r\n\r\n### Describe what you have tested and on which operating system.\r\nOpen RV Rocky 9 build system instructions were validated on a branch new\r\nRocky 9 installation.\r\n\r\n### Add a list of changes, and note any that might need special\r\nattention during the review.\r\n\r\n### If possible, provide screenshots.\r\n\r\nSigned-off-by: Bernard Laberge ","shortMessageHtmlLink":"Remove unnecessary cmake build from rocky9 setup (#474)"}},{"before":"3ec54d257a9e2c7ecb8f7395d67a3fcae775d87a","after":"9844fa4c218f3decb61ae29388ac97099ca51a46","ref":"refs/heads/main","pushedAt":"2024-05-29T12:57:46.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"bernie-laberge","name":"Bernard Laberge","path":"/bernie-laberge","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/117092886?s=80&v=4"},"commit":{"message":"[ 423: Non RHEL building ] (#424)\n\nFixes #423\r\n\r\n### Summarize your change.\r\nHave removed the blocking of trying to build on non-RHEL distro and\r\nchanged to only use lib64 on RHEL distros.\r\n\r\n### Describe the reason for the change.\r\nUnable to build on eg. Ubuntu\r\n\r\n### Describe what you have tested and on which operating system.\r\nHave tested with Ubuntu 20.04 using a custom build of Qt5 (and rest is\r\nstandard repo packages)\r\n\r\n### Add a list of changes, and note any that might need special\r\nattention during the review.\r\nHave not (yet) tested on a RHEL distro, but have made changes that\r\ndifferentiate between RHEL and non-RHEL Linux distros\r\n\r\n---------\r\n\r\nSigned-off-by: Jimmy Christensen \r\nCo-authored-by: Bernard Laberge <117092886+bernie-laberge@users.noreply.github.com>","shortMessageHtmlLink":"[ 423: Non RHEL building ] (#424)"}},{"before":"ca3a46756e7ff922eea640f49b710fc8cb6cf2eb","after":"3ec54d257a9e2c7ecb8f7395d67a3fcae775d87a","ref":"refs/heads/main","pushedAt":"2024-05-29T12:55:10.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"bernie-laberge","name":"Bernard Laberge","path":"/bernie-laberge","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/117092886?s=80&v=4"},"commit":{"message":"463: Unanonymised QMutexLocker usage in OCIOIPNode.cpp (#476)\n\n### Linked issues\r\nShould fix\r\n[#463](https://github.com/AcademySoftwareFoundation/OpenRV/issues/463)\r\n\r\n### Summarize your change.\r\nAdded \"lock\" variable name to all anonymous QMutexLocker instances to\r\nextend their lifespan to the end of their scope. This matches the\r\nQMutexLocker usage in other parts of the app (RVConsoleWindow.cpp and\r\nQTAudioRenderer.cpp).\r\n\r\n### Describe the reason for the change\r\nEnabling OCIO was causing frequent crashing when reader threads were set\r\ngreater than 1, in particular under MacOS Sonoma.\r\n\r\nSigned-off-by: kenmcgaugh ","shortMessageHtmlLink":"463: Unanonymised QMutexLocker usage in OCIOIPNode.cpp (#476)"}},{"before":"950ec03afeefa4a0ead147adae8ec685fbee9753","after":"ca3a46756e7ff922eea640f49b710fc8cb6cf2eb","ref":"refs/heads/main","pushedAt":"2024-05-28T19:55:29.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"bernie-laberge","name":"Bernard Laberge","path":"/bernie-laberge","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/117092886?s=80&v=4"},"commit":{"message":"Make OpenRV buildable on Xcode 15 (#475)\n\n### Linked issues\r\n\r\nFixes #278\r\n\r\n### Summarize your change.\r\n\r\nOpenRV will now default to using Boost 1.81 if the user has Xcode 15 or\r\ngreater. Otherwise, OpenRV will default to using Boost 1.80, which is\r\ncompliant with CY 2023 and works with Xcode 14.3.1. This also is\r\noutlined for the user in changes to documentation.\r\n\r\n### Describe the reason for the change.\r\n\r\nXcode 14.3.1 is deprecated on macOS Sonoma in favour of Xcode 15 and up,\r\nwhich means users on Sonoma or later will not be able to build OpenRV\r\nwithout this change.\r\n\r\n### Describe what you have tested and on which operating system.\r\n\r\nA complete build of OpenRV using `rvbootstrap` on macOS Sonoma and Xcode\r\n15.\r\n\r\n### Add a list of changes, and note any that might need special\r\nattention during the review.\r\n\r\n- [ ] CMake automatically uses Boost 1.80 if the Clang version provided\r\nby Xcode is less than 15\r\n\r\n---------\r\n\r\nSigned-off-by: Ben Chamberland \r\nSigned-off-by: Mark Reid \r\nCo-authored-by: Mark Reid \r\nCo-authored-by: Bernard Laberge <117092886+bernie-laberge@users.noreply.github.com>","shortMessageHtmlLink":"Make OpenRV buildable on Xcode 15 (#475)"}},{"before":"bbd2c3fad8be17ae753348b8c6ae67e1f780e078","after":"950ec03afeefa4a0ead147adae8ec685fbee9753","ref":"refs/heads/main","pushedAt":"2024-05-23T19:52:44.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"bernie-laberge","name":"Bernard Laberge","path":"/bernie-laberge","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/117092886?s=80&v=4"},"commit":{"message":"RVPaint fix segment edge intersection when path has variable widths (#439)\n\nThis fixes an issue when using the annotation tools and having strokes\r\nwith variable widths.\r\n\r\nVariable widths happen when you use a stylus/wacom tablet with pen\r\npressure. When widths can vary, it is possible for the widths of the\r\nstroke be just right so that the extruded edges become nearly parallel.\r\nThis case currently isn't being handled. This creates \"spikes\" on your\r\nbrush stroke that can seemly appear at random.\r\n\r\n## Example Of The Spikes Occurring\r\n\r\n\r\nhttps://github.com/AcademySoftwareFoundation/OpenRV/assets/814966/b7f1dd3f-1eee-4d62-97ec-add94ac12e11\r\n\r\n## Isolated Case\r\nHere is a minimal isolated case of the issue happening\r\n[spike_isolated.rv.](https://github.com/AcademySoftwareFoundation/OpenRV/files/14950061/spike_isolated.rv.zip)\r\n\r\n\r\n![image](https://github.com/AcademySoftwareFoundation/OpenRV/assets/814966/81f53ac9-2775-439d-b3e7-493e1b0ddf1f)\r\n\r\nI also graphed the polygons in desmos so its easier to see\r\nhttps://www.desmos.com/calculator/gxmkrpdr2o\r\n\r\nThe issue occurs when the point of intersection is calculated between\r\nline segments AB and CD.\r\n\r\n![image](https://github.com/AcademySoftwareFoundation/OpenRV/assets/814966/a6963e34-5377-45a9-a33d-dc64e0416e84)\r\n\r\nAs we can see the two lines are is nearly parallel. \r\n\r\n![image](https://github.com/AcademySoftwareFoundation/OpenRV/assets/814966/55ebb6e0-5099-41ff-9a20-c4180924615f)\r\n\r\nWhen intersection point is calculated, away we go!\r\n\r\n![image](https://github.com/AcademySoftwareFoundation/OpenRV/assets/814966/033dfef3-c2d5-4cf1-8cf1-cb6864c0b3a1)\r\n\r\n## The Solution\r\n\r\nTo fix this issue, I changed the code to perform the intersection as if\r\nthe line has a constant width. This was the simplest thing I could think\r\nof. The spikes never seem to happen with constant width strokes.\r\n\r\nSigned-off-by: Mark Reid \r\nCo-authored-by: Bernard Laberge <117092886+bernie-laberge@users.noreply.github.com>","shortMessageHtmlLink":"RVPaint fix segment edge intersection when path has variable widths (#…"}},{"before":"86f4464e6a8fc46bc6a7fa5032ea05352914e99c","after":"bbd2c3fad8be17ae753348b8c6ae67e1f780e078","ref":"refs/heads/main","pushedAt":"2024-05-21T18:05:26.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"cedrik-fuoco-adsk","name":"Cédrik Fuoco","path":"/cedrik-fuoco-adsk","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/105517825?s=80&v=4"},"commit":{"message":"Use autotools for PCRE2.cmake (Windows Only) (#465)\n\n### Use autotools for PCRE2.cmake (Windows Only)\r\n\r\n### Linked issues\r\n#462 \r\n\r\n### Summarize your change.\r\nChanging back to autotools instead of CMake for PCRE2.\r\n\r\n### Describe the reason for the change.\r\nA few weeks ago, I changed the build for PCRE2 to use CMake instead of\r\nautotools, but it seems like it is causing some issue on some Windows\r\nsetups from the community.\r\n\r\nThis is the same code as before the changes to CMake.\r\n\r\n### Describe what you have tested and on which operating system.\r\nWindows\r\n\r\n### Add a list of changes, and note any that might need special\r\nattention during the review.\r\n\r\n### If possible, provide screenshots.\r\n\r\nSigned-off-by: Cédrik Fuoco ","shortMessageHtmlLink":"Use autotools for PCRE2.cmake (Windows Only) (#465)"}},{"before":"fdf3f34fec1670ea60ac71de6e494713784818a5","after":null,"ref":"refs/heads/revert-461-native-apple-arm64","pushedAt":"2024-05-21T17:52:45.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"cedrik-fuoco-adsk","name":"Cédrik Fuoco","path":"/cedrik-fuoco-adsk","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/105517825?s=80&v=4"}},{"before":"e78d986e9333a0ef05787b91e53afb7544fa39d1","after":"86f4464e6a8fc46bc6a7fa5032ea05352914e99c","ref":"refs/heads/main","pushedAt":"2024-05-21T17:52:44.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"cedrik-fuoco-adsk","name":"Cédrik Fuoco","path":"/cedrik-fuoco-adsk","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/105517825?s=80&v=4"},"commit":{"message":"Revert \"Support native Apple ARM64\" (#467)\n\nI discovered some issues that I need to investigate. I think it would be\r\nbetter to revert until they are investigated.\r\n\r\nSigned-off-by: Cédrik Fuoco ","shortMessageHtmlLink":"Revert \"Support native Apple ARM64\" (#467)"}},{"before":"92f2835dad16ef058589a4ee8bff72dc0a713419","after":"fdf3f34fec1670ea60ac71de6e494713784818a5","ref":"refs/heads/revert-461-native-apple-arm64","pushedAt":"2024-05-17T22:23:43.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"cedrik-fuoco-adsk","name":"Cédrik Fuoco","path":"/cedrik-fuoco-adsk","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/105517825?s=80&v=4"},"commit":{"message":"Revert \"Support native Apple ARM64 (#461)\"\n\nThis reverts commit e78d986e9333a0ef05787b91e53afb7544fa39d1.\n\nSigned-off-by: Cédrik Fuoco ","shortMessageHtmlLink":"Revert \"Support native Apple ARM64 (#461)\""}},{"before":null,"after":"92f2835dad16ef058589a4ee8bff72dc0a713419","ref":"refs/heads/revert-461-native-apple-arm64","pushedAt":"2024-05-17T22:11:28.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"cedrik-fuoco-adsk","name":"Cédrik Fuoco","path":"/cedrik-fuoco-adsk","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/105517825?s=80&v=4"},"commit":{"message":"Revert \"Support native Apple ARM64 (#461)\"\n\nThis reverts commit e78d986e9333a0ef05787b91e53afb7544fa39d1.","shortMessageHtmlLink":"Revert \"Support native Apple ARM64 (#461)\""}},{"before":"e31d1d0194bb743d125c3dbaa5730cc9cf22f9ea","after":"e78d986e9333a0ef05787b91e53afb7544fa39d1","ref":"refs/heads/main","pushedAt":"2024-05-16T15:39:25.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"cedrik-fuoco-adsk","name":"Cédrik Fuoco","path":"/cedrik-fuoco-adsk","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/105517825?s=80&v=4"},"commit":{"message":"Support native Apple ARM64 (#461)\n\n# Support native Apple ARM64\r\n\r\n### Linked issues\r\nn/a\r\n\r\n### Summarize your change.\r\n\r\nSupporting both x86_64 and arm64 native build. You can build x86_64 on\r\nMacOS if you run the build under a terminal launched with `arch -x86_64`\r\n(using Rosetta).\r\n\r\nI made changes to some dependencies under `cmake/dependencies` to\r\nstandardized the `configure`, `command` and `install` command used in\r\n`externalproject_add` since some dependencies were using a mix of CMake\r\nand Make command.\r\n\r\n### Describe the reason for the change.\r\nSupport native build of Apple chipset.\r\n\r\n### Describe what you have tested and on which operating system.\r\n\r\n- [x] MacOS\r\n- [x] Windows (CI)\r\n- [x] Rocky Linux 9 (CI)\r\n\r\n### Add a list of changes, and note any that might need special\r\nattention during the review.\r\n\r\n### If possible, provide screenshots.\r\n\r\n---------\r\n\r\nSigned-off-by: Cédrik Fuoco ","shortMessageHtmlLink":"Support native Apple ARM64 (#461)"}},{"before":"40ac4dfae21984dda6fc62b632a7963eec4b3da1","after":"e31d1d0194bb743d125c3dbaa5730cc9cf22f9ea","ref":"refs/heads/main","pushedAt":"2024-05-03T12:41:17.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"cedrik-fuoco-adsk","name":"Cédrik Fuoco","path":"/cedrik-fuoco-adsk","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/105517825?s=80&v=4"},"commit":{"message":"Split ZLIB patch into two patches (#460)\n\n### Split ZLIB patch into two patches\r\n\r\n### Linked issues\r\n#459 \r\n\r\n### Summarize your change.\r\nSplit the patch into two patches\r\n\r\n### Describe the reason for the change.\r\nThe patch file had changes for multiple files and it causes issues on\r\nmacOS. I separated the patch into two files to resolves the issue.\r\n\r\n### Describe what you have tested and on which operating system.\r\nMacOS\r\n\r\n### Add a list of changes, and note any that might need special\r\nattention during the review.\r\nn/a\r\n\r\n### If possible, provide screenshots.\r\nn/a\r\n\r\nSigned-off-by: Cédrik Fuoco ","shortMessageHtmlLink":"Split ZLIB patch into two patches (#460)"}},{"before":"390d96e8c9cdb22c016319ae447bb7bc9a3daf9d","after":"40ac4dfae21984dda6fc62b632a7963eec4b3da1","ref":"refs/heads/main","pushedAt":"2024-04-30T18:42:42.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"cedrik-fuoco-adsk","name":"Cédrik Fuoco","path":"/cedrik-fuoco-adsk","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/105517825?s=80&v=4"},"commit":{"message":"Merge FFmpeg 6 feature branch into main by cherry-picking (#456)\n\n### Merge FFmpeg 6 feature branch into main by cherry-picking\r\n\r\n### Linked issues\r\n#388 \r\n\r\n### Summarize your change.\r\nMerge FFmpeg 6 feature branch into main by cherry-picking\r\n\r\n### Describe the reason for the change.\r\nUpdate OpenRV to FFmpeg 6\r\n\r\n### Describe what you have tested and on which operating system.\r\n\r\n- [x] Windows\r\n- [x] MacOS\r\n- [x] Rocky Linux\r\n\r\n### Add a list of changes, and note any that might need special\r\nattention during the review.\r\nn\\a\r\n\r\n### If possible, provide screenshots.\r\nn\\a\r\n\r\n---------\r\n\r\nSigned-off-by: Sebastian Parborg \r\nSigned-off-by: Cédrik Fuoco <105517825+cedrik-fuoco-adsk@users.noreply.github.com>\r\nSigned-off-by: Cédrik Fuoco \r\nSigned-off-by: Cédrik Fuoco \r\nCo-authored-by: DarkDefender ","shortMessageHtmlLink":"Merge FFmpeg 6 feature branch into main by cherry-picking (#456)"}},{"before":"f1ebbfd343057d46ea7eeb00aa8137fb6ad2981c","after":"b6dcb17df2a194f866d0fd6d4dc17cefe15640ba","ref":"refs/heads/feature/ffmpeg-6-update","pushedAt":"2024-04-30T14:33:07.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"cedrik-fuoco-adsk","name":"Cédrik Fuoco","path":"/cedrik-fuoco-adsk","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/105517825?s=80&v=4"},"commit":{"message":"FFmpeg-6 Preparing for the merge (#452)\n\n### FFmpeg-6 Preparing for the merge\r\n\r\n### Linked issues\r\nn/a\r\n\r\n### Summarize your change.\r\nn/a\r\n\r\n### Describe the reason for the change.\r\nRe-signing the commits before merging the feature branch since the DCO\r\nwas failing in the draft PR I opened for the merge.\r\n\r\n### Describe what you have tested and on which operating system.\r\nn/a\r\n\r\n### Add a list of changes, and note any that might need special\r\nattention during the review.\r\nn/a\r\n\r\n### If possible, provide screenshots.\r\nn/a\r\n\r\n---------\r\n\r\nSigned-off-by: Sebastian Parborg \r\nSigned-off-by: Cédrik Fuoco <105517825+cedrik-fuoco-adsk@users.noreply.github.com>\r\nSigned-off-by: Cédrik Fuoco \r\nSigned-off-by: Bernard Laberge \r\nSigned-off-by: Cédrik Fuoco \r\nSigned-off-by: Brian R Hanke <59420805+BrianHanke@users.noreply.github.com>\r\nCo-authored-by: DarkDefender \r\nCo-authored-by: Bernard Laberge <117092886+bernie-laberge@users.noreply.github.com>\r\nCo-authored-by: Brian R Hanke <59420805+BrianHanke@users.noreply.github.com>","shortMessageHtmlLink":"FFmpeg-6 Preparing for the merge (#452)"}},{"before":"d4b9983c0539ac5593ad03226e33efee923d64e1","after":"390d96e8c9cdb22c016319ae447bb7bc9a3daf9d","ref":"refs/heads/main","pushedAt":"2024-04-29T16:45:18.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"cedrik-fuoco-adsk","name":"Cédrik Fuoco","path":"/cedrik-fuoco-adsk","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/105517825?s=80&v=4"},"commit":{"message":"Fix issue with OTIO in debug on Windows (#449)\n\n### Fix issue with OTIO in debug on Windows\r\n\r\n### Linked issues\r\nn/a\r\n\r\n### Summarize your change.\r\n- [x] Fix issue with `OTIO` in debug on Windows by specifying the\r\nlibrary file and includes directly to CMake.\r\n- [x] Fix an issue in debug on Windows where `ZLIB (release)` was found\r\nin MinGW system files **and** where `ZLIB` was found in RV_DEPS_ZLIB\r\n(debug). Both were linked and it was causing issue with `minizip-ng`. I\r\nthink it is an issue with `minizip-ng`, but the fix makes sure that we\r\nonly linked to the right one.\r\n- [x] Sets `IMPORTED_IMPLIB` for `SSL` and `Crypto` target on Windows\r\n- [x] Use `CMake` instead of the configure script and make for PCRE2\r\n(Windows only).\r\n\r\n### Describe the reason for the change.\r\nLong standing instability with OTIO in debug on Windows. I always had\r\nissues building OpenRV in debug on Windows due to OTIO. This PR makes\r\nthe debug build more stable, and I can build OpenRV in debug straight\r\nfrom a fresh cloned repository.\r\n\r\n### Describe what you have tested and on which operating system.\r\n- [x] Windows\r\n\r\n### Add a list of changes, and note any that might need special\r\nattention during the review.\r\nn/a\r\n\r\n### If possible, provide screenshots.\r\nn/a\r\n\r\nSigned-off-by: Cédrik Fuoco ","shortMessageHtmlLink":"Fix issue with OTIO in debug on Windows (#449)"}},{"before":"494107a6a4cbdf199d38e9336f0d8ba98d7f9318","after":"d4b9983c0539ac5593ad03226e33efee923d64e1","ref":"refs/heads/main","pushedAt":"2024-04-29T12:09:41.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"cedrik-fuoco-adsk","name":"Cédrik Fuoco","path":"/cedrik-fuoco-adsk","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/105517825?s=80&v=4"},"commit":{"message":"Enable PNG decoder on Windows (#448)\n\n### Enable PNG decoder on Windows\r\n\r\n### Linked issues\r\n#447 \r\n\r\n### Summarize your change.\r\nMake sure that FFmpeg knows where to find ZLIB library. ZLIB is needed\r\nby the PNG decoder.\r\n\r\nZLIB had to be patched to be used during FFmpeg build on Windows. Note\r\nthat the patch comes from the ZLIB port of Vcpkg.\r\n\r\n### Describe the reason for the change.\r\nPNG movies were not able to be decoded because PNG decoder in FFmpeg was\r\ndisabled due to missing ZLIB library during the build of FFmpeg.\r\n\r\nSince ZLIB is installed by default on MacOS and Linux, it wasn't a\r\nproblem on those systems. But it means that the wrong ZLIB was used by\r\nFFmpeg (not the one compiled by OpenRV).\r\n\r\n### Describe what you have tested and on which operating system.\r\n- [x] Windows only\r\n\r\n### Add a list of changes, and note any that might need special\r\nattention during the review.\r\nn/a\r\n\r\n### If possible, provide screenshots.\r\nn/a\r\n\r\nSigned-off-by: Cédrik Fuoco ","shortMessageHtmlLink":"Enable PNG decoder on Windows (#448)"}},{"before":"602b518bf635161b8939c47302d17955b28d1c3b","after":"f1ebbfd343057d46ea7eeb00aa8137fb6ad2981c","ref":"refs/heads/feature/ffmpeg-6-update","pushedAt":"2024-04-26T20:08:52.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"cedrik-fuoco-adsk","name":"Cédrik Fuoco","path":"/cedrik-fuoco-adsk","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/105517825?s=80&v=4"},"commit":{"message":"FFmpeg 6 - Disabling aac_at in OpenRV (#450)\n\n# Disabling aac_at in OpenRV\r\n\r\n### Linked issues\r\nn/a\r\n\r\n### Summarize your change.\r\nDisabling aac_at decoder in OpenRV\r\n\r\n### Describe the reason for the change.\r\nDisabling aac_at decoder in OpenRV \r\n\r\n### Describe what you have tested and on which operating system.\r\n\r\n### Add a list of changes, and note any that might need special\r\nattention during the review.\r\n\r\n### If possible, provide screenshots.\r\n\r\nSigned-off-by: Cédrik Fuoco ","shortMessageHtmlLink":"FFmpeg 6 - Disabling aac_at in OpenRV (#450)"}},{"before":"f90c4db2672c84bd8f9e1874d71491af24e3882a","after":"494107a6a4cbdf199d38e9336f0d8ba98d7f9318","ref":"refs/heads/main","pushedAt":"2024-04-16T15:17:55.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"cedrik-fuoco-adsk","name":"Cédrik Fuoco","path":"/cedrik-fuoco-adsk","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/105517825?s=80&v=4"},"commit":{"message":"[444: Add _install directory to .gitignore] (#445)\n\n\r\n\r\n### Linked issues\r\n\r\n\r\n### Summarize your change.\r\n\r\nAdded the default _install/* target directory to the repository's\r\n.gitignore.\r\n\r\n### Describe the reason for the change.\r\n\r\nThe _build directories were already ignored, this looks like an\r\noversight?\r\n\r\n### Describe what you have tested and on which operating system.\r\n\r\n### Add a list of changes, and note any that might need special\r\nattention during the review.\r\n\r\n### If possible, provide screenshots.\r\n\r\nSigned-off-by: Gergely Wootsch ","shortMessageHtmlLink":"[444: Add _install directory to .gitignore] (#445)"}},{"before":"63dc8d804526ea6be0c3cacf6f5b77c39a3bd190","after":"602b518bf635161b8939c47302d17955b28d1c3b","ref":"refs/heads/feature/ffmpeg-6-update","pushedAt":"2024-04-16T12:28:26.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"cedrik-fuoco-adsk","name":"Cédrik Fuoco","path":"/cedrik-fuoco-adsk","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/105517825?s=80&v=4"},"commit":{"message":"Rebase ffmpeg-6-update branch (#446)\n\n### Rebase ffmpeg-6-update branch\r\n\r\n### Linked issues\r\nn/a\r\n\r\n### Summarize your change.\r\nRebase ffmpeg-6-update branch\r\n\r\n### Describe the reason for the change.\r\nRebase ffmpeg-6-update branch\r\n\r\n### Describe what you have tested and on which operating system.\r\nn/a\r\n\r\n### Add a list of changes, and note any that might need special\r\nattention during the review.\r\nn/a\r\n\r\n### If possible, provide screenshots.\r\nn/a\r\n\r\n---------\r\n\r\nSigned-off-by: Bernard Laberge \r\nSigned-off-by: Cédrik Fuoco \r\nSigned-off-by: Brian R Hanke <59420805+BrianHanke@users.noreply.github.com>\r\nSigned-off-by: Sebastian Parborg \r\nSigned-off-by: Cédrik Fuoco <105517825+cedrik-fuoco-adsk@users.noreply.github.com>\r\nSigned-off-by: Cédrik Fuoco \r\nCo-authored-by: Bernard Laberge <117092886+bernie-laberge@users.noreply.github.com>\r\nCo-authored-by: Brian R Hanke <59420805+BrianHanke@users.noreply.github.com>\r\nCo-authored-by: DarkDefender ","shortMessageHtmlLink":"Rebase ffmpeg-6-update branch (#446)"}},{"before":"245fcae94da9e0054830de8474f763556c4723f4","after":"63dc8d804526ea6be0c3cacf6f5b77c39a3bd190","ref":"refs/heads/feature/ffmpeg-6-update","pushedAt":"2024-04-12T15:01:25.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"cedrik-fuoco-adsk","name":"Cédrik Fuoco","path":"/cedrik-fuoco-adsk","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/105517825?s=80&v=4"},"commit":{"message":"[FFmpeg 6] Fix build issue of FFmpeg / libcrypto (#440)\n\n### [FFmpeg 6] Fix build issue of FFmpeg / libcrypto\r\n\r\n### Linked issues\r\n#388 \r\n\r\n### Summarize your change.\r\nFix issue with the build (specifically on Rocky Linux 9)\r\n\r\n### Describe the reason for the change.\r\nThere were link issues for RV executable because libcrypto was not found\r\nby the linker.\r\n\r\n### Describe what you have tested and on which operating system.\r\nTested the build and ran OpenRV on:\r\n\r\n- [x] Windows\r\n- [x] Rocky Linux 8 and 9\r\n- [x] MacOS\r\n\r\n### Add a list of changes, and note any that might need special\r\nattention during the review.\r\nn/a\r\n\r\n### If possible, provide screenshots.\r\nn/a\r\n\r\nSigned-off-by: Cédrik Fuoco ","shortMessageHtmlLink":"[FFmpeg 6] Fix build issue of FFmpeg / libcrypto (#440)"}},{"before":"526bfdcc62b687d71849eb0578461d1b7572bcaa","after":"245fcae94da9e0054830de8474f763556c4723f4","ref":"refs/heads/feature/ffmpeg-6-update","pushedAt":"2024-04-10T19:10:46.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"cedrik-fuoco-adsk","name":"Cédrik Fuoco","path":"/cedrik-fuoco-adsk","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/105517825?s=80&v=4"},"commit":{"message":"[FFmpeg 6 Update] Fix issues by adding missing code (#432)\n\n### [FFmpeg 6 Update] Fix issues by adding missing code\r\n\r\n### Linked issues\r\n#388\r\n\r\n### Summarize your change.\r\nFixed issue with addTrack method, added back some code to fix a crash\r\nwhen exporting and added back some code to fix a infinite loop while\r\ndecoding audio.\r\n\r\n### Describe the reason for the change.\r\nFFmpeg 6 update\r\n\r\n### Describe what you have tested and on which operating system.\r\n- [ ] Rocky Linux 8\r\n\r\n### Add a list of changes, and note any that might need special\r\nattention during the review.\r\nn/a\r\n\r\n### If possible, provide screenshots.\r\nn/a\r\n\r\n---------\r\n\r\nSigned-off-by: Cédrik Fuoco \r\nSigned-off-by: Cédrik Fuoco ","shortMessageHtmlLink":"[FFmpeg 6 Update] Fix issues by adding missing code (#432)"}},{"before":"17274aac7c2fc1b5899ea551ce28149848eb804a","after":"f90c4db2672c84bd8f9e1874d71491af24e3882a","ref":"refs/heads/main","pushedAt":"2024-04-10T12:53:40.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"cedrik-fuoco-adsk","name":"Cédrik Fuoco","path":"/cedrik-fuoco-adsk","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/105517825?s=80&v=4"},"commit":{"message":"Fix crashes on CentOS7 by tweaking the error handling of libpng (#421)\n\n### Fix crashes on CentOS by tweaking the error handling of libpng\r\n\r\n### Linked issues\r\nFixes #420\r\n\r\n### Summarize your change.\r\nModified the custom error handler to support the jmpbuf address instead\r\nof relying on libpng to save the address.\r\nIt should make sure that the calling convention are similar.\r\n\r\n### Describe the reason for the change.\r\nOpenRV was crashing (CentOS7) when opening images sequence of PNGs that\r\nhad incomplete PNG.\r\n\r\n### Describe what you have tested and on which operating system.\r\n\r\n- [x] Rocky Linux 8\r\n- [x] CentOS 7\r\n- [ ] Windows (todo)\r\n- [ ] MacOS (todo)\r\n\r\nI tested the following:\r\n\r\n- [x] Opened a PNG image sequence with incomplete PNGs\r\n- [x] Opened an incomplete PNG image\r\n- [x] Opened a PNG image sequence\r\n\r\n### Add a list of changes, and note any that might need special\r\nattention during the review.\r\nn/a\r\n\r\n### If possible, provide screenshots.\r\nn/a\r\n\r\nSigned-off-by: Cédrik Fuoco ","shortMessageHtmlLink":"Fix crashes on CentOS7 by tweaking the error handling of libpng (#421)"}},{"before":"1738a62e58a8c498b21e808adc2e0be5a0565925","after":"17274aac7c2fc1b5899ea551ce28149848eb804a","ref":"refs/heads/main","pushedAt":"2024-04-09T19:17:30.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"bernie-laberge","name":"Bernard Laberge","path":"/bernie-laberge","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/117092886?s=80&v=4"},"commit":{"message":"Add P216 video output buffer format (#436)\n\n### Add P216 video output buffer format\r\n\r\n### Linked issues\r\nNA\r\n\r\n### Summarize your change.\r\n\r\nThis commit adds P216 video output buffer format support to Open RV.\r\n\r\nP216 \r\nThis is a 4:2:2 buffer in semi-planar format with full 16bpp color\r\nprecision. This is formed from two buffers in memory, the first is a\r\n16bpp\r\nluminance buffer and the second is a buffer of U,V pairs in memory. \r\n\r\n### Describe the reason for the change.\r\n\r\nThis format is the 16 bits internal buffer format representation used by\r\nthe NDI SDK which will allow an upcoming version of Open RV to support\r\nthe NDI SDK 6.0.0 with 10 bits support.\r\n\r\n### Describe what you have tested and on which operating system.\r\nTested on macOS \r\n\r\n### Add a list of changes, and note any that might need special\r\nattention during the review.\r\n\r\n### If possible, provide screenshots.\r\n\r\nSigned-off-by: Bernard Laberge ","shortMessageHtmlLink":"Add P216 video output buffer format (#436)"}},{"before":"56a1ac7473ae1588caaac46fd50d10a78ca26fd1","after":"1738a62e58a8c498b21e808adc2e0be5a0565925","ref":"refs/heads/main","pushedAt":"2024-04-04T14:03:02.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"bernie-laberge","name":"Bernard Laberge","path":"/bernie-laberge","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/117092886?s=80&v=4"},"commit":{"message":"433: Fix Playback stopping when RV is completely overlapped on macOS (#434)\n\n### 433: Fix Playback stopping when RV is completely overlapped on macOS\r\n\r\n### Linked issues\r\nFixes #433\r\n\r\n### Summarize your change.\r\nMake sure that the QGLWidget gets redrawn by updateGL() even when\r\ncompletely overlapped by another window.\r\n\r\n### Describe the reason for the change.\r\nOn macOS, Qt correctly detects when the QGLWidget is completely\r\noverlapped by another window and in which case resets the Qt::WA_Mapped\r\nattribute. This prevents the GLView::paintGL() operation from being\r\ncalled by m_view->updateGL(), which will result in automatically\r\ninterrupting any video playback that might be in progress while the RV\r\nwindow is completely overlapped.\r\nThis is an undesirable behaviour during a review session, especially if\r\nan external video output device is used.\r\n\r\n### Describe what you have tested and on which operating system.\r\nTested on macOS Sonoma 14.0\r\n\r\n### Add a list of changes, and note any that might need special\r\nattention during the review.\r\n\r\n### If possible, provide screenshots.\r\n\r\nSigned-off-by: Bernard Laberge ","shortMessageHtmlLink":"433: Fix Playback stopping when RV is completely overlapped on macOS (#…"}},{"before":"59ad3169013c570516a0c9b6cde8deafbea74de1","after":"526bfdcc62b687d71849eb0578461d1b7572bcaa","ref":"refs/heads/feature/ffmpeg-6-update","pushedAt":"2024-04-03T20:06:27.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"cedrik-fuoco-adsk","name":"Cédrik Fuoco","path":"/cedrik-fuoco-adsk","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/105517825?s=80&v=4"},"commit":{"message":"Rebase feature branch ffmpeg-6-update to main (#431)\n\n### Rebase feature branch ffmpeg-6-update to main\r\n\r\n### Linked issues\r\nn/a\r\n\r\n### Summarize your change.\r\nRebase feature branch ffmpeg-6-update to main\r\n\r\n### Describe the reason for the change.\r\nEasier to do PR afterwards\r\n\r\n### Describe what you have tested and on which operating system.\r\nn/a\r\n\r\n### Add a list of changes, and note any that might need special\r\nattention during the review.\r\nn/a\r\n\r\n### If possible, provide screenshots.\r\nn/a\r\n\r\n---------\r\n\r\nSigned-off-by: Bernard Laberge \r\nSigned-off-by: Cédrik Fuoco \r\nSigned-off-by: Brian R Hanke <59420805+BrianHanke@users.noreply.github.com>\r\nCo-authored-by: Bernard Laberge <117092886+bernie-laberge@users.noreply.github.com>\r\nCo-authored-by: Brian R Hanke <59420805+BrianHanke@users.noreply.github.com>","shortMessageHtmlLink":"Rebase feature branch ffmpeg-6-update to main (#431)"}},{"before":"dce1b6246fdca4491ee66a0f09f438aafde5e0c2","after":"56a1ac7473ae1588caaac46fd50d10a78ca26fd1","ref":"refs/heads/main","pushedAt":"2024-04-02T13:25:13.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"cedrik-fuoco-adsk","name":"Cédrik Fuoco","path":"/cedrik-fuoco-adsk","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/105517825?s=80&v=4"},"commit":{"message":"Update openrv-pub submodule, missing changes (#429)\n\n### Update openrv-pub submodule, missing a change\r\n\r\n### Linked issues\r\n#427 \r\n\r\n### Summarize your change.\r\nThe root CMakelists.txt was not updated in the last openrv-pub submodule\r\nupdate.\r\n\r\n### Describe the reason for the change.\r\nIssue with OpenRV build.\r\n\r\n### Describe what you have tested and on which operating system.\r\nAffect Windows only.\r\n\r\n### Add a list of changes, and note any that might need special\r\nattention during the review.\r\nn/a\r\n\r\n### If possible, provide screenshots.\r\nn/a\r\n\r\nSigned-off-by: Cédrik Fuoco ","shortMessageHtmlLink":"Update openrv-pub submodule, missing changes (#429)"}},{"before":"6a328a5b5383225335ecbfe3316eb95b703da578","after":"dce1b6246fdca4491ee66a0f09f438aafde5e0c2","ref":"refs/heads/main","pushedAt":"2024-03-26T17:37:44.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"cedrik-fuoco-adsk","name":"Cédrik Fuoco","path":"/cedrik-fuoco-adsk","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/105517825?s=80&v=4"},"commit":{"message":"Update openrv-pub submodule (#422)\n\n### Update openrv-pub submodule\r\n\r\n### Linked issues\r\nn/a\r\n\r\n### Summarize your change.\r\nUpdate openrv-pub submodule which removes PCRE from it.\r\n\r\n### Describe the reason for the change.\r\nUpdate to PCRE2\r\n\r\n### Describe what you have tested and on which operating system.\r\nWindows (not used on Linux/MacOS)\r\n\r\n### Add a list of changes, and note any that might need special\r\nattention during the review.\r\nn/a\r\n\r\n### If possible, provide screenshots.\r\nn/a\r\n\r\nSigned-off-by: Cédrik Fuoco ","shortMessageHtmlLink":"Update openrv-pub submodule (#422)"}},{"before":"c607d69e2a222e689a518b1d02228054fac96644","after":"6a328a5b5383225335ecbfe3316eb95b703da578","ref":"refs/heads/main","pushedAt":"2024-03-21T11:49:34.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"bernie-laberge","name":"Bernard Laberge","path":"/bernie-laberge","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/117092886?s=80&v=4"},"commit":{"message":"Fix audio cache issue #418 (#419)\n\n### 418: Fix audio cache stopped being filled issue \r\n\r\n### Linked issues\r\n\r\nFixes #418\r\n\r\n### Summarize your change.\r\n\r\nNow incrementing the next audio samples to be read and added to the\r\ncache but only AFTER checking that it is not out the current audio\r\ncaching range (head + tail).\r\n\r\nWithout this fix, the next audio sample to be read and added to the\r\ncache (m_currentAudioSample) is incremented beyond the audio caching\r\nrange and remains out of range until the playback is stopped which leads\r\nto audio silence once the play head goes out of the audio cache range.\r\nIf you look carefully at the audio cache drawn above the timeline, you\r\nwill see that there is an increasing audio sample that is momentarily\r\ncached and then disappears because it is out of the audio caching range\r\n(head+tail):\r\n\"audio_sample_trying_to_escape\"\r\nsrc=\"https://github.com/AcademySoftwareFoundation/OpenRV/assets/117092886/74ac57f0-a707-4c87-bf9c-13da21c90a25\"\r\n\r\n\r\n### Describe the reason for the change.\r\n\r\nNote that I discovered this audio issue today while testing the NDI\r\nvideo output.\r\n\r\nIt was puzzling me big time because I was only able to reproduce it with\r\nNDI in presentation mode.\r\nNote that the audio cache should be behaving pretty much the same way no\r\nmatter which audio output is used: standard audio output or NDI audio\r\noutput.\r\nBut after some investigation, I was able to reproduce the same issue\r\nwithout NDI by forcing an audio frame size of 2000 via the -audiofs 2000\r\nrv command line option (which is what NDI is using).\r\n\r\n### Describe what you have tested and on which operating system.\r\nSuccessfully tested on macOS\r\n\r\n### Add a list of changes, and note any that might need special\r\nattention during the review.\r\n\r\n### If possible, provide screenshots.\r\n\r\nSigned-off-by: Bernard Laberge ","shortMessageHtmlLink":"Fix audio cache issue #418 (#419)"}},{"before":"94fc0a64660a860b4a0fa090425346b0f8b154ac","after":"c607d69e2a222e689a518b1d02228054fac96644","ref":"refs/heads/main","pushedAt":"2024-03-19T20:16:37.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"cedrik-fuoco-adsk","name":"Cédrik Fuoco","path":"/cedrik-fuoco-adsk","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/105517825?s=80&v=4"},"commit":{"message":"Replacing PCRE with PCRE2 (#401)\n\n### Replacing PCRE with PCRE2\r\n\r\n### Linked issues\r\nRelated PR in\r\n[openrv-pub](https://github.com/shotgunsoftware/openrv-pub/pull/14). I\r\nwasn't able to assign any reviewers for the PR there.\r\n\r\n### Summarize your change.\r\nAdded PCRE2 as a dependencies under cmake/dependencies for Windows only\r\nbecause the code uses Boost regex for Linux and Mac. Leaving it like\r\nthis to minimize any impact.\r\n\r\n### Describe the reason for the change.\r\nPhase out dependencies from the pub repository and hoping for less\r\nvulnerability and security issue since PCRE2 is actively maintained.\r\n\r\n### Describe what you have tested and on which operating system.\r\nTested on Windows.\r\n\r\n### Add a list of changes, and note any that might need special\r\nattention during the review.\r\nn/a\r\n\r\n### If possible, provide screenshots.\r\nn/a\r\n\r\n---------\r\n\r\nSigned-off-by: Cédrik Fuoco ","shortMessageHtmlLink":"Replacing PCRE with PCRE2 (#401)"}},{"before":"9b45df8d0caf0a9ed174a0a3d615a43831f5bacf","after":"59ad3169013c570516a0c9b6cde8deafbea74de1","ref":"refs/heads/feature/ffmpeg-6-update","pushedAt":"2024-03-19T20:13:10.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"bernie-laberge","name":"Bernard Laberge","path":"/bernie-laberge","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/117092886?s=80&v=4"},"commit":{"message":"388: Make OpenRV compile and playback videos with ffmpeg 6.1.1 (#389)\n\nFixes #388\r\n\r\n### Summarize your change.\r\nThis updates the ffmpeg backend to ffmpeg version 6.1.1. Note that there\r\nare still some variable deprecation warnings.\r\nHowever it builds and seems to run.\r\n\r\n### Describe the reason for the change.\r\nffmpeg 4 is on its way out, so It would be good to update to ffmpeg 6.\r\n\r\nNote that I did not update the build system as I had to heavily modify\r\nit to make it build on my system.\r\nI'm not building ffmpeg for OpenRV but instead I linked ffmpeg 6 from my\r\nsystem install.\r\n\r\n### Describe what you have tested and on which operating system.\r\nI have tested playback of different video files (H.264, AV1 etc) on my\r\nGentoo Linux machine.\r\nHowever I haven't run this through ASAN or done any thorough testing.\r\n\r\nI posted this now as I saw the issue ticket and wanted to make sure that\r\nno duplicate work is done.\r\n\r\n---------\r\n\r\nSigned-off-by: Sebastian Parborg \r\nSigned-off-by: Cédrik Fuoco <105517825+cedrik-fuoco-adsk@users.noreply.github.com>\r\nCo-authored-by: Cédrik Fuoco <105517825+cedrik-fuoco-adsk@users.noreply.github.com>","shortMessageHtmlLink":"388: Make OpenRV compile and playback videos with ffmpeg 6.1.1 (#389)"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEVvtqkwA","startCursor":null,"endCursor":null}},"title":"Activity · AcademySoftwareFoundation/OpenRV"}