Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribute space is ignored for viewdirection node #1656

Open
hybridherbst opened this issue Jan 17, 2024 · 1 comment
Open

Attribute space is ignored for viewdirection node #1656

hybridherbst opened this issue Jan 17, 2024 · 1 comment

Comments

@hybridherbst
Copy link
Contributor

hybridherbst commented Jan 17, 2024

Seems the viewdirection node has a space property but it actually doesn't do anything in https://academysoftwarefoundation.github.io/MaterialX/,

when modifying space to model | object | world the result is identical:
edge_brighten copy.mtlx.zip

Is this intentional?

@jstone-lucasfilm
Copy link
Member

Good catch, @hybridherbst, and it looks like only the OSL implementation of viewdirection supports the space property in the initial pull request. This would be a much appreciated contribution if developers in the community have the bandwidth to extend this support to GLSL and MSL.

https://github.com/AcademySoftwareFoundation/MaterialX/blob/main/libraries/nprlib/genosl/nprlib_genosl_impl.mtlx#L15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants