Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API call to convert channels attributes to nodes #1652

Open
kwokcb opened this issue Jan 16, 2024 · 1 comment
Open

Add API call to convert channels attributes to nodes #1652

kwokcb opened this issue Jan 16, 2024 · 1 comment

Comments

@kwokcb
Copy link
Contributor

kwokcb commented Jan 16, 2024

Issue

It is possible to either miss or bypass the channels attribute on an input
If this occurs this can fail validation due to input / output type being found to be different types.

(Note: There also appears to be issues with how this attribute can sometimes not propagate properly
with interface inputs and outputs.)

Suggestion

Add a convenience utility to convert implicit channels attributes to explicit nodes (such as an extract,
swizzle etc)

@jstone-lucasfilm jstone-lucasfilm changed the title Suggestion: Add utility to convert implicit "channel" extract to explicit nodes Add API call to convert channels attributes to nodes Feb 28, 2024
@jstone-lucasfilm
Copy link
Member

Thanks for this report, @kwokcb, and I'll just add a note that this will be addressed by the design changes in MaterialX 1.39, which includes the replacement of channels attributes with explicit nodes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants