Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph Editor: Handle Nodegraph Implementations in Non-Library files. #1651

Open
kwokcb opened this issue Jan 16, 2024 · 0 comments
Open

Graph Editor: Handle Nodegraph Implementations in Non-Library files. #1651

kwokcb opened this issue Jan 16, 2024 · 0 comments

Comments

@kwokcb
Copy link
Contributor

kwokcb commented Jan 16, 2024

Issue

  • Currently nodegraph implementations which are embedded in non-ibrary files which are loaded in are
    viewable and editable.
  • The definition does not show up as an option for adding a new node.

Suggestion

  • Either hide or template (make read-only) these graphs.
  • Add the definition to the "add" UI. This should be discussed as to what it means if the file is unloaded -- should the definition stay or not. Suggestion is to mark and clear these definitions on a new file load / file clear.

Example:

Load in the OpenPBR combined file provided in OpenPBR slack (included here) into editor.
The nodegraph implementation (circled) loads in and is editable.

image
[open_pbr_surface_combined - .txt]
(https://github.com/AcademySoftwareFoundation/MaterialX/files/13951690/open_pbr_surface_combined.-.txt)

@jstone-lucasfilm jstone-lucasfilm changed the title MaterialX Node Editor Suggestion: Handle Nodegraph Implementations in Non-Library files. Graph Editor: Handle Nodegraph Implementations in Non-Library files. May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant