Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated integration tests #53

Open
vesely-david opened this issue Apr 9, 2021 · 2 comments
Open

Automated integration tests #53

vesely-david opened this issue Apr 9, 2021 · 2 comments

Comments

@vesely-david
Copy link
Collaborator

No description provided.

@vesely-david
Copy link
Collaborator Author

Enabling automated integration tests is a key for increasing productivity of development and confidence in the code in general.

Proposed way:

I think we can take confluent_kafka repository as inspiration.
They run the integration tests in 2 ways:

  • using trivup library, to automatically start a simple kafka cluster and test against it.
  • run the test against existing kafka cluster when it is available

In my understanding, we could write the tests as follows:

  • default to trivup so it could be run automatically as github action
  • every developer has the option to run it locally against his own kafka cluster

Happy to discuss. @felipemmelo @DanWertheimer what are your thoughts/suggestions?

@felipemmelo
Copy link
Contributor

VERY happy with this approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants