Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure testing and Single Elimination Improvements #49

Merged
merged 2 commits into from
May 7, 2023
Merged

Restructure testing and Single Elimination Improvements #49

merged 2 commits into from
May 7, 2023

Conversation

AaronAshery
Copy link
Owner

No description provided.

@AaronAshery AaronAshery linked an issue May 6, 2023 that may be closed by this pull request
Restructure Testing #30
Closed
@AaronAshery AaronAshery added the enhancement New feature or request label May 6, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 6, 2023 •
edited

Codecov Report

Merging #49 (967d4e1) into main (2111a52) will increase coverage by 3.20%.
The diff coverage is 99.35%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
+ Coverage   95.97%   99.18%   +3.20%     
==========================================
  Files           4       10       +6     
  Lines         373      489     +116     
  Branches       29       38       +9     
==========================================
+ Hits          358      485     +127     
+ Misses         10        2       -8     
+ Partials        5        2       -3
Impacted Files Coverage Δ
no_teg/no_teg.py 98.18% <ø> (+6.71%) ⬆️
no_teg/tourneys/round_robin.py 97.56% <97.56%> (ø)
no_teg/tourneys/single_elimination.py 98.38% <98.38%> (ø)
no_teg/games/fifa.py 100.00% <100.00%> (ø)
no_teg/tests/conftest.py 100.00% <100.00%> (ø)
no_teg/tests/test_all.py 100.00% <100.00%> (ø)
no_teg/tests/test_round_robin.py 100.00% <100.00%> (ø)
no_teg/tests/test_single_elimination.py 100.00% <100.00%> (ø)

@AaronAshery
restrusctured entire project to have interfaces and subfolders for th…
11e8f16 
…e implementations

Finished single elim testing and fixed single elim bugs

started rr test file

linting

reworked round robin to be more balanced. added tests for round robin tournament
@AaronAshery AaronAshery merged commit 12035bc into main May 7, 2023
6 checks passed
@AaronAshery AaronAshery linked an issue May 8, 2023 that may be closed by this pull request
Restructure default games #29
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request in progress testing
Projects
Project Management
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restructure default games Restructure Testing
2 participants
@AaronAshery @codecov-commenter