Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uart.c constant comparison issues #1039

Open
b4yuan opened this issue Aug 2, 2023 · 0 comments
Open

uart.c constant comparison issues #1039

b4yuan opened this issue Aug 2, 2023 · 0 comments
Assignees
@flit

Comments

@b4yuan
Copy link

b4yuan commented Aug 2, 2023

In multiple uart.c files:

line 164 in source/hic_hal/freescale/kl27z/uart.c:
line 149 in source/hic_hal/freescale/kl26z/uart.c:
line 140 in source/hic_hal/freescale/kl26z/uart.c:
line 134 in source/hic_hal/freescale/k20dx/uart.c:

The comparison if (data_bits == 2) { is made, but data_bits is always <= 1; the comparison will always resolve to false.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flit flit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@flit @b4yuan