Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Generalize masking option into a weighting option for registration #1437

Open
gdevenyi opened this issue Oct 21, 2022 · 7 comments
Labels
feature request Ideas for new or improved ANTs features

Comments

@gdevenyi
Copy link
Contributor

Hard edge masks require the masks to be as-near-to-possible to perfect to perform optimally for guiding registrations.

If instead the masks were considered as a weight option (if say the masks contain a distribution of values 0-1) then one could do something like blur the mask so the edges are now a gradient which relaxes the perfection requirement some.

There are likely option useful things I can't think of that would benefit from weights.

@dorianps
Copy link
Collaborator

I had asked about this sometime ago (can't find the issue, maybe an email), but was told it was not easy to implement. I agree, would be great to have weighted masks, it would open the way to all sorts of masks derived from various scenarios. It would also need some heavy testing of how they can be used (i.e., would fading the bran edge impair gyral registration compared to a binary mask).

@cookpa cookpa added the feature request Ideas for new or improved ANTs features label Oct 21, 2022
@ntustison
Copy link
Member

This would require significant changes to the ITK image metrics. As they are currently written, the masks dictate which voxels are used for computation---a binary proposition, hence the hard masks as input. As such, this feature request should be made over on the ITK side. I would recommend closing this issue here and opening it over there.

@cookpa
Copy link
Member

cookpa commented Oct 21, 2022

@gdevenyi are you using binary masks as fixed and moving images? Or you're saying binary masks with -x causes the registration to align mask boundaries?

@gdevenyi
Copy link
Contributor Author

What I'm proposing is the -x option generalize to floating point numbers to weight the registration rather than an include/exclude

@stnava
Copy link
Member

stnava commented Oct 21, 2022 via email

@gdevenyi
Copy link
Contributor Author

Got it @stnava I missed your earlier comment. I'll move this up to ITK

@gdevenyi
Copy link
Contributor Author

Upstreamed, InsightSoftwareConsortium/ITK#3704

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Ideas for new or improved ANTs features
Projects
None yet
Development

No branches or pull requests

5 participants