Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suite.py: Avoid Duplicates in addToCompileString #83

Open
ax3l opened this issue Sep 7, 2021 · 0 comments
Open

suite.py: Avoid Duplicates in addToCompileString #83

ax3l opened this issue Sep 7, 2021 · 0 comments

Comments

@ax3l
Copy link
Member

ax3l commented Sep 7, 2021

Potentially needs a backport from @EZoni in ECP-WarpX#13:

This should fix ECP-WarpX/WarpX#2068.

This PR can be tested by running

./run_test.sh Langmuir_multi_2d_nodal Langmuir_multi_2d_psatd

from a local WarpX installation, with and without the changes in this PR. With the changes in this PR, we avoid two duplicate builds for the two tests above, by removing the duplicate build option USE_PSATD=TRUE (otherwise appearing twice) from the final compile string.

Note that you will have to modify run_test.sh by commenting and replacing the following line

#git clone https://github.com/ECP-WarpX/regression_testing.git
cp -r /<path_to>/regression_testing .

in order to use your local clone of the regression testing repository (and thus be able to switch between the master branch and the branch of this PR).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant