Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also consider it a crash if doComparison is False and the return code is non-zero #78

Open
ax3l opened this issue Sep 7, 2021 · 0 comments

Comments

@ax3l
Copy link
Member

ax3l commented Sep 7, 2021

Potentially needs a backport from @atmyers in ECP-WarpX#1 :

We apparently don't consider a non-zero exit code a failure unless self.run_as_script is True. When doing plotfile comparisons, this isn't a big issue, since the comparison itself will fail as the test did not produce any output. However, when we run through travis we turn off comparisons, so we need to check the exit code.

An alternative fix would be to consider all non-zero exit codes a failure. In principle I prefer this, but I don't know the reasoning behind the original behavior here, so I'd like to be conservative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant