Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test suite fails with invalid path before creating web directory #39

Open
RemiLehe opened this issue Feb 28, 2019 · 2 comments
Open

Test suite fails with invalid path before creating web directory #39

RemiLehe opened this issue Feb 28, 2019 · 2 comments

Comments

@RemiLehe
Copy link
Contributor

It seems that #33 introduced a small bug:

The code is now calling

        if not os.path.isdir(self.webTopDir):

            self.log.fail("ERROR: Unable to initialize web directory to"
                    + " {} - invalid path.".format(self.webTopDir))

before calling

os.mkdir(full_test_dir)

(fundamentally, this is because, in the function test_suite, the above check/error happens in load_params, which is called before make_test_dirs)

So if the web directory is not created by hand before running the test script, the test suite will crash early on.

@RemiLehe RemiLehe changed the title Test suite fails with invalid path before creating creating web directory Test suite fails with invalid path before creating web directory Feb 28, 2019
@zingale
Copy link
Member

zingale commented Mar 2, 2019

can you test this issue with the latest version?

@zingale
Copy link
Member

zingale commented Apr 26, 2020

is this still an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants