restart tests: do not hard-code 5 digits #119
Labels
Comments
ax3l
added a commit
to ax3l/WarpX
that referenced
this issue
Mar 2, 2022
Same as other CI restart tests: hard-coded value in regression suite makes this necessary. X-ref: AMReX-Codes/regression_testing#119
ax3l
added a commit
to ax3l/WarpX
that referenced
this issue
Mar 3, 2022
Same as other CI restart tests: hard-coded value in regression suite makes this necessary. X-ref: AMReX-Codes/regression_testing#119
ax3l
added a commit
to ax3l/WarpX
that referenced
this issue
Mar 3, 2022
Same as other CI restart tests: hard-coded value in regression suite makes this necessary. X-ref: AMReX-Codes/regression_testing#119
ax3l
added a commit
to ax3l/WarpX
that referenced
this issue
Mar 3, 2022
Same as other CI restart tests: hard-coded value in regression suite makes this necessary. X-ref: AMReX-Codes/regression_testing#119
ax3l
added a commit
to ax3l/WarpX
that referenced
this issue
Mar 3, 2022
Same as other CI restart tests: hard-coded value in regression suite makes this necessary. X-ref: AMReX-Codes/regression_testing#119
ax3l
added a commit
to ax3l/WarpX
that referenced
this issue
Mar 3, 2022
Same as other CI restart tests: hard-coded value in regression suite makes this necessary. X-ref: AMReX-Codes/regression_testing#119
ax3l
added a commit
to ax3l/WarpX
that referenced
this issue
Mar 3, 2022
Same as other CI restart tests: hard-coded value in regression suite makes this necessary. X-ref: AMReX-Codes/regression_testing#119
RemiLehe
pushed a commit
to ECP-WarpX/WarpX
that referenced
this issue
Mar 3, 2022
* file_min_digits: 5->6 100k+ step runs are quite common in WarpX. To simplify post-processing scripts, increase the default to pad to 6 digits. This might break some hand-written scripts that use `?????` wild-cards over `*` wildcards in regex and thus need to be updated. But it at the same time simplifies regexes for analysis of data series and listing of such file series. * Update Scripts to Handle New File Names * Fix CI Test pml_x_psatd * Fix CI Test divb_cleaning_3d * Fix CI Tests with EB Support * Fix CI Tests with RZ Support * Fix CI Tests with PICMI Support * Use glob in Analysis of Collision Tests * Use rstrip in Analysis of Collision Tests * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix CI Tests for Langmuir_multi_1d/psatd * Fix CI Tests for LaserInjection_1d * Checkpoint-Restart Tests: 5 Digits `regtest.py` in `regression_testing` hard-codes 5 digits: ```diff --- a/regtest.py +++ b/regtest.py @@ -734,7 +734,7 @@ def test_suite(argv): shutil.move(test.diffDir, orig_diff_dir) # get the file number to restart from - restart_file = "%s_chk%5.5d" % (test.name, test.restartFileNum) + restart_file = "%s_chk%6.6d" % (test.name, test.restartFileNum) ``` * PICMI Restart Tests: `warpx_file_min_digits = 5` Same as other CI restart tests: hard-coded value in regression suite makes this necessary. X-ref: AMReX-Codes/regression_testing#119 Co-authored-by: Edoardo Zoni <ezoni@lbl.gov> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
WarpX simulations can run multi-million steps and beyond.
The hard-coded 5 digits for
restart_fileneed to be replaced with an option or even better, a search & regex:regression_testing/regtest.py
Line 724 in 4b290c5
X-ref: ECP-WarpX/WarpX#2385
The text was updated successfully, but these errors were encountered: