New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ParticleContainer::RedistributeCPU for Pure SoA #3744

Open

2 tasks

ax3l opened this issue Feb 2, 2024 · 0 comments

Assignees

Labels

Member

ax3l commented Feb 2, 2024 •

edited

For pure SoA particle layouts, we see on CPU that ParticleContainer::RedistributeCPU takes 8-9% longer than the legacy layout. ECP-WarpX/WarpX#4653

I think we can probably avoid this by optimizing the pack/unpack routines for the new layout a bit more:

check and avoid if we still use the legacy aos layout for some of the communication - ensure we perform nice and long array copies
use the new id validate/invalidate routines from Add ParticleIDWrapper::make_invalid() #3735

x-ref: #2878 #3299

The text was updated successfully, but these errors were encountered:

ax3l added the performance label

ax3l assigned atmyers

ax3l mentioned this issue

Particle Container to Pure SoA Again ECP-WarpX/WarpX#4653

Merged

4 tasks

ax3l mentioned this issue

convert to pure SoA particle containers quokka-astro/quokka#515

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment