Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

still have issues with pressure in 1-d momentum fluxes #2803

Open
zingale opened this issue Mar 25, 2024 · 1 comment
Open

still have issues with pressure in 1-d momentum fluxes #2803

zingale opened this issue Mar 25, 2024 · 1 comment

Comments

@zingale
Copy link
Member

zingale commented Mar 25, 2024

It looks like we adding the pressure to the momntum flux in 1-d Cartesian in scale_flux(), but I think this is wrong -- it should already be added since mom_flux_has_p is always true for Cartesian. So I think that we need to remove this addition in advection_util.cpp
@zingale
Copy link
Member Author

zingale commented Apr 6, 2024

it looks like this was missed in #2468

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zingale