Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mhd_eigen values are unused #2783

Open
zingale opened this issue Mar 18, 2024 · 0 comments
Open

mhd_eigen values are unused #2783

zingale opened this issue Mar 18, 2024 · 0 comments
Labels

Comments

@zingale
Copy link
Member

zingale commented Mar 18, 2024

In computing the eigensystem of the MHD equations in mhd_eigen.H, we have logic like:

  if (std::abs(cfz-csz) <= 1e-14){
    alf = 1.0_rt;
    als = 0.0_rt;
  }

  if (as - csz < 0.0) {
    alf = 0.0_rt;
  } else {
    alf = std::sqrt((as - csz)/(cfz - csz));
  }

  if (cfz - as < 0.0) {
    als = 0.0_rt;
  } else {
    als = std::sqrt((cfz - as)/(cfz - csz));
  }

So the values set in the first test are never used, since they are overwritten by the else in the next 2 tests.

This was identified by clang-tidy

@zingale zingale added the mhd label Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant