Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split c-linter action in 2 #2746

Open
zingale opened this issue Feb 9, 2024 · 2 comments
Open

split c-linter action in 2 #2746

zingale opened this issue Feb 9, 2024 · 2 comments

Comments

@zingale
Copy link
Member

zingale commented Feb 9, 2024

Right now the c-linter action does clang-tidy and claims to do cppcheck. We should split it in two.

For the clang-tidy, we should use the build process that is in AMReX currently (USE_CLANG_TIDY=TRUE).

For cppcheck, we should make sure it is actually running and make an artifact from the output.

@yut23
Copy link
Collaborator

yut23 commented Feb 20, 2024

One of the considerations is that cppcheck uses a compilation database to pick up the right options and files. It might be possible to do something with make print-CXXFLAGS etc instead, but I'm not sure.

@zingale
Copy link
Member Author

zingale commented Apr 22, 2024

we now have a separate clang-tidy action, so I am not sure if we even need this one anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants