Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create an API for updating runtime parameters #2701

Open
zingale opened this issue Jan 4, 2024 · 1 comment
Open

create an API for updating runtime parameters #2701

zingale opened this issue Jan 4, 2024 · 1 comment
Labels

Comments

@zingale
Copy link
Member

zingale commented Jan 4, 2024

For most runtime parameters, we read them at initialization and they never change. But we have a few cases where depending on the values of other parameters, we change some. This should be done explicitly through a setter function so we can catch changes when we transition to structs for the runtime parameters.

Here's a partial list of runtime parameters that we override:

  • do_reflux (in Castro.cpp, read_params())
  • rot_axis (in Castro.cpp, read_params())
  • sdc_iters (in Castro_advance_ctu.cpp)
  • small_temp, small_dens, small_pres, small_ener (all in Castro_setup.cpp)
  • rotational_period (in Castro_io.cpp, scf_relax.cpp)
  • point_mass (in Castro_io.cpp, Castro_pointmass.cpp)
@zingale
Copy link
Member Author

zingale commented Jan 4, 2024

these were found using #2702

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant