Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

have reaction loop print out failures even when on GPU #2515

Open
zingale opened this issue Jul 3, 2023 · 3 comments
Open

have reaction loop print out failures even when on GPU #2515

zingale opened this issue Jul 3, 2023 · 3 comments

Comments

@zingale
Copy link
Member

zingale commented Jul 3, 2023

Currently, when running on the GPU, the different integrators do not print out the failures. But we now have standardized error codes, which we can add to the burn_t. Then we can store these in Castro to output once we leave the GPU kernel.

Some of this is discussed here:

AMReX-Astro/Microphysics#705

@zingale
Copy link
Member Author

zingale commented Jul 3, 2023

In an ideal world, we'd setup a vector<burn_t> in Castro outside of the loop over the MF and then push back the burn_t of any zone that fails. Then outside of the GPU kernel, we'd loop over the vector and print out the failures.

This can really help with debugging.

Is there a way to do this easily with GPUs?

@maxpkatz maxpkatz self-assigned this Jul 3, 2023
@maxpkatz
Copy link
Member

maxpkatz commented Jul 4, 2023

If you add the error code as a burn_t member, there's a couple ideas I have here for how to do some version of this.

@zingale
Copy link
Member Author

zingale commented Jul 4, 2023

the error codes are added to the burn_t in this PR:
AMReX-Astro/Microphysics#1254

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants