Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MADDPG init issues #334

Open
khanrezwan opened this issue Nov 26, 2023 · 1 comment
Open

MADDPG init issues #334

khanrezwan opened this issue Nov 26, 2023 · 1 comment

Comments

@khanrezwan
Copy link

Following is my code

import elegantrl.agents.AgentMADDPG

a1 = elegantrl.agents.AgentMADDPG.AgentMADDPG()

Output: AgentMADDPG.py
in __init__ super().__init__()
TypeError: __init__() missing 3 required positional arguments: 'net_dims', 'state_dim', and 'action_dim'

It is due to incorrect inheritance from of AgentBase class.

@afeser
Copy link

afeser commented Jan 6, 2024

I also have the same problem.
After fixing this, I got other issues in this class.
I think there is a room for some refactoring (even rewriting -> docs old/missing, no examples, old function calls etc.)

If this is not solved yet, I can do it; but if anyone knows this is already solved, it'd make my job lots easier : )

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants