Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with missing value #129

Open
cardiomoon opened this issue Jan 13, 2022 · 3 comments
Open

Error with missing value #129

cardiomoon opened this issue Jan 13, 2022 · 3 comments

Comments

@cardiomoon
Copy link

Thank you for nice package !

But dabest function result in ERROR when data[[y]] has missing value(s).

Best,

Keon-Woong Moon

@josesho
Copy link
Member

josesho commented Jan 13, 2022

Hi @cardiomoon ,

As noted in the readme, could you please provide a copy-pastable reproducible example with dummy data? This is to help diagnose to issue faster.

Thank,
Joses

@cardiomoon
Copy link
Author

This is reproducible example

data(mtcars)
dabest(mtcars,am,mpg,idx=c("0","1")) %>% mean_diff()  # No error
mtcars$mpg[1:10]=NA
dabest(mtcars,am,mpg,idx=c("0","1")) %>% mean_diff()  #  error

@ZHANGROU-99
Copy link

Hi @cardiomoon ,

Thanks for your suggestion and the reproducible example. Yes, curret version of dabestr result in error when data has missing value. We will improve this in the next version. For now, please drop missing value before calling dabestr.

Best,
Zhang Rou

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants