Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider deprecating @ConfSerialisers? #32

Open
gepron1x opened this issue Jan 2, 2022 · 1 comment
Open

Consider deprecating @ConfSerialisers? #32

gepron1x opened this issue Jan 2, 2022 · 1 comment
Labels
feedback wanted Feedback especially wanted on this issue
Milestone

Comments

@gepron1x
Copy link

gepron1x commented Jan 2, 2022

This way to declare serialisers forces you to use singletones. Those ones are not the best practice in the object oriented programming.
Since there's already a better solution, using ConfigurationOptions, i suggest deprecating @ConfSerialisers annotation, or, at least, showing another way in documentation.

@A248 A248 added this to the 1.3.0 milestone Jan 2, 2022
@A248 A248 added the feedback wanted Feedback especially wanted on this issue label Jan 2, 2022
@A248 A248 modified the milestones: 1.3.0, 2.0.0 Aug 30, 2023
@A248
Copy link
Owner

A248 commented Aug 30, 2023

I agree with deprecating @ConfSerialisers. Another limitation of this annotation is that it intends for value serializers to be confined to the specific config interface annotated. This behavior doesn't seem very useful; in almost all cases, the serializers should be registered globally instead.

Since we've received no other feedback on this issue, the annotation will be deprecated in 1.3.0. For 2.0 we'll simply remove the annotation entirely. If absolutely needed, we can re-add it, but I highly doubt such would happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback wanted Feedback especially wanted on this issue
Projects
None yet
Development

No branches or pull requests

2 participants