Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build interpolation into Chart components by default (phase 2) #23

Open
dxinteractive opened this issue Feb 9, 2017 · 0 comments
Open

Comments

@dxinteractive
Copy link
Contributor

Say if we set a frame prop on a Chart, the Chart then internally uses chartData.frameAtIndexInterpolated() and its results are used for rendering values. However, default scales should continue to use the original chartData object so that the results of min and max are done on the whole data set and not just the current frame in time.

frameAtIndexInterpolated() accepts 3 args, which we should be able to get like:

  • frameColumn corresponds to a Chart's timeColumn or something like that
  • primaryColumn should be able to be automatic, hopefully, because most chart types intrinsically has a primary column (Line / column = x, bar = y, scatter doesn't have one so will need to be specified by the user somehow)
  • index can just use Chart's frame prop
@dxinteractive dxinteractive changed the title Build interpolation into Charts by default (phase 2) Build interpolation into Chart components by default (phase 2) Feb 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant