Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 - index based methods should be turned into keys before creating actions out of them #275

Open
dxinteractive opened this issue Jan 15, 2020 · 0 comments

Comments

@dxinteractive
Copy link
Collaborator

This is so when e.g. parcel.pop() or parcel.shift() are called on rebased data, the items being removed are done so by key and not by position in the array, or else unexpected items will disappear.

My data: [1,2,3]
I pop() and now have [1,2]
I rebase on top of someone elses changes (e.g. [1,2,3,4])

  • current scenario is that after rebase I'll have [1,2,3], because 4 was popped off
  • correct scenario is that after rebase I'll have [1,2,4], because I saw that the 3 was deleted as the result of the pop()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant