Are the parameters to computeProfitMaximizingTrade correct?

[tthil]

The call to the smart contract function computeProfitMaximizingTrade takes 4 parameters (sReserve0, sReserve1, uReserve0, uReserve1)
The parameter list in the smart contract is defined as
computeProfitMaximizingTrade(
uint256 truePriceTokenA,
uint256 truePriceTokenB,
uint256 reserveA,
uint256 reserveB

My question is if sReserve0 and sReserve1 really are truePriceTokenA and truePriceTokenB?

[0xNagato]

Were you able to improve this?

[tthil]

Hi, No, I moved on. I felt like this repo is dead and more of a test. //Thomas

…

On 17 Nov 2022, at 00:53, 0XFEZ ***@***.***> wrote: Were you able to improve this? — Reply to this email directly, view it on GitHub <#24 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAPF26ZPJQJF7BA63BSRBBTWIUNSJANCNFSM6AAAAAAQV6VQJQ>. You are receiving this because you authored the thread.

[0xNagato]

Did you have any luck finding any good ones? I'm very stuck

[tthil]

I decided to dig deeper into by myself and build it from scratch as it is more to it than just the interaction with the smart contract. //Thomas

…

On 17 Nov 2022, at 10:57, 0XFEZ ***@***.***> wrote: Did you have any luck finding any good ones? I'm very stuck — Reply to this email directly, view it on GitHub <#24 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAPF265NXNDUBFILXCO6KGLWIWUJJANCNFSM6AAAAAAQV6VQJQ>. You are receiving this because you authored the thread.

[manzub]

Hi Thomas, I do want to build it myself too but i need inspiration to build a more competitive bot joining this late