Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start at login, hide from Dock, deny calls at notification and custom ringtone #417

Closed
dioobr opened this issue Jan 15, 2018 · 10 comments
Closed

Comments

@dioobr
Copy link

dioobr commented Jan 15, 2018

Hi,

I would like to make four suggestions:

  1. Option to start the app after login. I know it's possible to define this by the dock, but according to my second suggestion, an option in the preferences would be necessary;
  2. Enable to hide the app, without showing the icon in the Dock;
  3. Enable deny a call in the notification. Currently shows "Close" and "Reply". Even when you click "Close", the ringingtone continues;
  4. Custom ringtone;

Great app. The best, no doubt.
Bye!

** macOS Sierra 10.12.6

@berlinbikerx
Copy link

You can use custom ringtones already:

Put your wav file into ~/Library/Sounds and choose it in Settings -> Sound/Audio

@eofster
Copy link
Member

eofster commented Jan 19, 2018

It is possible to decline the call from a notification. But because of macOS limitations, neither there can be a third button there not can the Close button be used to decline a call. The way it is possible now is to hold the Answer button which reveals the Decline button.

@eofster
Copy link
Member

eofster commented Jan 19, 2018

Thanks for the feedback. As discussed above, custom ringtones and declining calls from notifications are already supported. We already have an issue for the menu bar icon (#14) which implies the ability to hide the icon from the Dock. And I’ve just created an issue for enabling “start at login” in app preferences (#422).

@eofster eofster closed this as completed Jan 19, 2018
@dioobr
Copy link
Author

dioobr commented Jan 19, 2018

I used another software for some time and the way the notification was displayed was one of the good things. From my point of view, a third button seems unnecessary.
screen shot 2018-01-19 at 12 40 27

@eofster
Copy link
Member

eofster commented Jan 19, 2018

Hmm, I wonder how they did that. The first button means “Close” even if the title is different. And the app doesn’t get a callback when that button is clicked.

@eofster
Copy link
Member

eofster commented Jan 19, 2018

I see, there’s probably a private method for that, but we can’t rely on this, especially when being on the Mac App Store.

@dioobr
Copy link
Author

dioobr commented Jan 19, 2018

I wasn't sure until you mention it, but I did a test here and in fact the "Decline" button declines the call, without showing any app windows.

@eofster
Copy link
Member

eofster commented Jan 19, 2018

Yep, this sounds like usage of that private method. The app just intercepts the Close button event and doesn’t get activated. Well, it would be good enough if that was a public method, but it’s not.

@dioobr
Copy link
Author

dioobr commented Jan 19, 2018

I understand. I figured it was simpler.
Another thing, wouldn't it be interesting an indicator with the number of lost calls in the icon? Like what that appears in the Mail icon when you receive a new message.

@eofster
Copy link
Member

eofster commented Jan 20, 2018

Thanks for the idea, created issue #428.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants