Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hidden entityType filterfacet for bulkExport functionality #439

Open
floriangantner opened this issue Mar 6, 2024 · 1 comment
Open

Comments

@floriangantner
Copy link

floriangantner commented Mar 6, 2024

Is your feature request related to a problem? Please describe.
The bulk export can only be triggered when the entityType filterfacet is configured on the discovery configuration. As a repository manager i might configure this facet on the default/site configuration, but not on relation boxes which mostly include only one entity type per tab. If the filterfacet is missing the export button will be shown with the available export formats, but in the modal the user will get some warning message. This is annoying for the user, because as an user i would expect that when there is some export button it offers me the possibility to export somethin.

No filters configured for configuration (entries exist)
Screenshot 2024-03-06 at 10-25-59 FIS Universität Bamberg Mein FIS

Publication button is shown:
Screenshot 2024-03-06 at 10-25-54 FIS Universität Bamberg Mein FIS

Modal shows message:
Screenshot 2024-03-06 at 10-24-48 FIS Universität Bamberg Mein FIS

Describe the solution you'd like
We would like some additional configurable property to hide filterfacets to be shown on specific search configurations. The facets are still calculated and delivered through the Rest-API, but simply not shown.

On the backend this could be achieved by some new list of DiscoverySearchFilterFacet hiddenSidebarFacets on the DiscoveryConfiguration itself which contains the beans which are not shown. This information is added and passed through the REST API as some extra property isHiddenOnSidebar on the SearchFacetEntryRest.

On the frontend this property is mapped in the search-filter-config.model and if the property is set than the filterfacet is hidden in the search-filters.component .

Describe alternatives or workarounds you've considered

  • check the current available entities for the query together with the list of available export formats.
  • Hide the export button when there are no entries

Additional context

@floriangantner floriangantner changed the title remove entityType filterfacet from bulkExport functionality hidden entityType filterfacet for bulkExport functionality Mar 6, 2024
@jsubhi
Copy link

jsubhi commented May 21, 2024

At least in our current installation of 2023.02.03 it seems to be enough to configure the entity-type filter as a searchFilter only and not as a sidebarFacet for the export to work. This way the entity-type filter only shows up on the corresponding search page in the dropdown next to the search field. This is still not optimal but much less better than having a redundant filter-facet in the sidebar.

One Exception are the Publications of a person and Publications of an Orgunit Pages. Here the export-Button does not work at all, even when the entity-type filter is added as a visible sidebar facet. This might be a separate bug, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants