Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limit xls-collection-crosswalk to group members #422

Open
floriangantner opened this issue Feb 8, 2024 · 0 comments · May be fixed by #432
Open

limit xls-collection-crosswalk to group members #422

floriangantner opened this issue Feb 8, 2024 · 0 comments · May be fixed by #432

Comments

@floriangantner
Copy link

floriangantner commented Feb 8, 2024

Is your feature request related to a problem? Please describe.
By default there is some crosswalk collection-xls to xls using the collection default submission form.
This is used for exporting the items via collection-export process. By default it is also shown for anonymous users in the export format list.
Most anonymous users are not sure how the structure is (what is the $$sl=? What are the separators? What is some placeholder?) and do not need these information; some more abstract export for anonymous users in xls is available using the CsvCrosswalk/XlsCrosswalk

Describe the solution you'd like
Implement the isAuthenticated method from the interface ItemExportCrosswalk as the others crosswalk do. This allow system administrators to limit it to Administrators and/or Anonymous users

Describe alternatives or workarounds you've considered

  • remove it from the crosswalks list. The bean should be initialized anyway and export is possible anyway

Additional context
https://github.com/4Science/DSpace/blob/main-cris/dspace-api/src/main/java/org/dspace/content/integration/crosswalks/XlsCollectionCrosswalk.java

floriangantner added a commit to uniba-ub/DSpace that referenced this issue Feb 28, 2024
implement interface method for fine granular check to export these issues only to Administrator group. Configured crosswalk to stay to the current behaviour (export to all)
4Science#422
@floriangantner floriangantner linked a pull request Feb 28, 2024 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant