Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Orcid affiliation validation checks optional start-date field as required #363

Open
floriangantner opened this issue Jul 21, 2023 · 1 comment · May be fixed by #364
Open

Orcid affiliation validation checks optional start-date field as required #363

floriangantner opened this issue Jul 21, 2023 · 1 comment · May be fixed by #364
Labels
bug

Comments

@floriangantner
Copy link

Describe the bug
The validation check checks affiliation.startdate as required.

DSpace/dspace-api/src/main/java/org/dspace/orcid/model/validator/impl/OrcidValidatorImpl.java

Line 140 in 47be259

if (affiliation.getStartDate() == null) {

Nevertheless according to the orcid scheme this property start-date is not required.

https://github.com/ORCID/orcid-model/blob/master/src/main/resources/common_3.0/common-3.0.xsd

To Reproduce
Steps to reproduce the behavior:

  1. Create some Profile with affiliation with education and startdate
  2. Connect to orcid and enable biographical settings for affiliation
  3. Push affiliation to ORcid

Expected behavior
Of course it's nice to have properly and valid data, but we expect to be able to set affiliation without some startdate.

Related work
Will provide some PR next week which will comment the regarding lines.
@floriangantner floriangantner changed the title Orcid affiliation validation checks optional field as required Orcid affiliation validation checks optional start-date field as required Jul 21, 2023
@floriangantner floriangantner linked a pull request Jul 24, 2023 that will close this issue
Open
8 tasks
@floriangantner
Copy link
Author

this might be related to #73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove optional affiliation startdate from orcid validation uniba-ub/DSpace
1 participant
@floriangantner