Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch field being String in FileComparison causing compareCommit to crash #769

Open
rojsrojs opened this issue Feb 18, 2022 · 0 comments
Open

patch field being String in FileComparison causing compareCommit to crash #769

rojsrojs opened this issue Feb 18, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@rojsrojs
Copy link

rojsrojs commented Feb 18, 2022 •
edited

Follow up from #746.

This is generally not true:

image

I noticed, if a very large change has been made (like 2000 row change of a file), which still has status modified, the patch field won't appear in that case either, which causes JsonParsingError(Invalid message body: Could not decode JSON: {..} error message.

Patch being Option[String] in all scenarios solves this issue.
@fedefernandez fedefernandez added the bug Something isn't working label Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fedefernandez @rojsrojs