Convert IRC formatting / emphasis to markdown for Mattermost #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hloeung
force-pushed
the
convert-formatting
branch
from
41ab91d
to
4a3948c
Compare
hloeung
force-pushed
the
convert-formatting
branch
2 times, most recently
from
fbb00d7
to
2df932d
Compare
hloeung
force-pushed
the
convert-formatting
branch
from
2df932d
to
df35e47
Compare
hloeung
changed the title
hloeung
changed the title
hloeung
changed the title
|
Added stripping of reverse and hex colors, so this covers all the cases as per #258 |
|
Not tested yet by me, but looks good :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #258
Per #258, this converts formatting/emphasis of IRC messages to markdown to Mattermost. Currently supported are bold, italics, bold+italics, monospace, and reset.
Testing with
irssi(which doesn't seem to let me test italics and monospace):(where B = Ctrl+B and O = Ctrl+O)
Produces:
Testing Testing Testing Testing Testing (reset)